Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(curriculum): add English curriculum block 7.2 Reading and understanding code documentation #54197

Merged
merged 7 commits into from May 14, 2024
Merged

feat(curriculum): add English curriculum block 7.2 Reading and understanding code documentation #54197

merged 7 commits into from May 14, 2024

Conversation

miyaliu666
Copy link
Member

Checklist:

@miyaliu666 miyaliu666 requested a review from a team as a code owner March 24, 2024 12:57
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels Mar 24, 2024
@miyaliu666 miyaliu666 added the new english course English Curriculum label Mar 24, 2024
moT01
moT01 reviewed May 7, 2024
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, found one minor typo I think.

...r-developers/learn-how-to-read-and-understand-code-documentation/65fd5d1a6cb7f10f77a06163.md Outdated Show resolved Hide resolved
@miyaliu666 @moT01
Apply suggestions from code review
5b34e4d 
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
@naomi-lgbt naomi-lgbt self-requested a review May 9, 2024 22:16
miyaliu666 and others added 2 commits May 12, 2024 12:38
@naomi-lgbt naomi-lgbt merged commit 4270793 into freeCodeCamp:main May 14, 2024
22 checks passed
@miyaliu666 miyaliu666 deleted the feat-7.2 branch May 15, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

@nieldakarla nieldakarla Awaiting requested review from nieldakarla

Assignees
No one assigned
Labels
new english course English Curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miyaliu666 @moT01 @naomi-lgbt