fix(curriculum): grammar issues and updated test in step 29 of music player project

[RGHANILOO]

Checklist:

• I have read and followed the contribution guidelines.
• I have read and followed the how to open a pull request guide.
• My pull request targets the main branch of freeCodeCamp.
• I have tested these changes either locally on my machine, or GitPod.

[jdwilkin4]

Hi @RGHANILOO !

It looks like there are a couple of issues with this PR.

The first issue is that your current PR doesn't have any files changed

Please push up another commit to add the changes you want to make so a review can be done.

The second issue is the PR title. It isn't clear what these changes are about.
It is best to use descriptive PR titles so matinainers know what the PR's are about.

A good title would be the following:

fix(curriculum): fix grammar issues and updated tests in step 29 of music player project

once those changes are applied, then we can properly review your PR 👍
If you need help with these changes, then please reach out on the contributors channel on discord or the contributors subforum. 👍

[RGHANILOO]

Hi

Thanks @jdwilkin4 for your feedback.
not sure what happened the first time round, i have now made the necessary changes again as highlighted.
Thanks

[jdwilkin4]

@RGHANILOO

It looks like some the tests are failing.
Can you please look into that?
It looks like the issue has to deal with the changes you made to one of the tests for the music player

[RGHANILOO]

@RGHANILOO

It looks like some the tests are failing. Can you please look into that? It looks like the issue has to deal with the changes you made to one of the tests for the music player

Hey @jdwilkin4 ,
i have made the appropriate changes based on a suggestion on another PR on this issue that satisfies all the described conditions.

[gikf]

Second test also needs to be changed, to add more lenient regex to it as well.

[gikf]

@RGHANILOO, sorry, I should be more clear. The second test is this one:

freeCodeCamp/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-basic-string-and-array-methods-by-building-a-music-player/653639d63a45a077333312c8.md

Lines 25 to 29 in c628dbc

	You should set `audio.currentTime` to `0` inside your `if` block.
	```js
	assert.match(code, /if\s*\(\s*userData\?\.currentSong\s*===\s*null\s*\|\|\s*userData\?\.currentSong\.id\s*!==\s*song\.id\s*\)\s*\{\s*audio\.currentTime\s*=\s*0\s*;?\s*\}/)
	```

Without updating it with similar pattern as first one, it will be able for condition that passes first test not pass second.

[jdwilkin4]

It looks like the steps have been updated and the changes should now be updated to step 38. not step 32.
I am going to close this PR.

I would suggest you do following:

• delete this branch
• update your main branch with the latest changes
• create a new branch
• create a new fresh PR with these changes and we will be happy to review that 👍