Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reorganise playwright config #53884

Merged
merged 4 commits into from Feb 26, 2024
Merged

chore: reorganise playwright config #53884

merged 4 commits into from Feb 26, 2024

Conversation

ojeytonwilliams
Copy link
Contributor

Checklist:

Playwright seems to expect to be run from the root and, if not, it does not automatically run project dependencies. i.e. global-setup.ts should run before any other tests, but does not if the dependencies are inside e2e/node_modules.

@ojeytonwilliams ojeytonwilliams requested a review from a team as a code owner February 26, 2024 10:50
@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label Feb 26, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Feb 26, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/plugin-transform-runtime@7.23.9 unsafe Transitive: environment, filesystem +32 12.2 MB nicolo-ribaudo
npm/@babel/preset-env@7.18.0 environment Transitive: filesystem, unsafe +120 21.8 MB nicolo-ribaudo
npm/@babel/preset-typescript@7.23.3 Transitive: environment, filesystem, unsafe +42 14.8 MB nicolo-ribaudo
npm/@babel/register@7.17.7 environment, filesystem, unsafe +38 17.7 MB nicolo-ribaudo
npm/@babel/register@7.23.7 environment, filesystem, unsafe +31 12.2 MB nicolo-ribaudo
npm/@babel/runtime@7.23.9 None 0 249 kB nicolo-ribaudo
npm/@babel/standalone@7.23.7 None 0 23.2 MB nicolo-ribaudo
npm/@compodoc/live-server@1.2.3 filesystem, network 0 53 kB compodoc
npm/@fastify/cookie@9.3.1 None 0 94.6 kB climba03003
npm/@fastify/csrf-protection@6.4.1 Transitive: eval +2 96.8 kB matteo.collina
npm/@fastify/express@2.3.0 None 0 60.3 kB matteo.collina
npm/@fastify/session@10.7.0 None 0 35.5 kB matteo.collina
npm/@fastify/swagger-ui@1.10.2 Transitive: network +4 5.7 MB eomm
npm/@fastify/swagger@8.14.0 None 0 303 kB climba03003
npm/@fastify/type-provider-typebox@3.6.0 None +1 1.36 MB matteo.collina
npm/@fortawesome/fontawesome-svg-core@6.4.2 None +1 1.09 MB robmadole
npm/@fortawesome/free-brands-svg-icons@6.4.2 None +1 2.79 MB robmadole
npm/@fortawesome/free-solid-svg-icons@6.4.2 None +1 5.78 MB robmadole
npm/@fortawesome/react-fontawesome@0.2.0 environment +2 1.12 MB robmadole
npm/@freecodecamp/curriculum-helpers@1.3.0 None 0 59 kB shaunshamilton
npm/@freecodecamp/loop-protect@3.0.0 None 0 15.8 kB ojeytonwilliams
npm/@freecodecamp/loopback-component-passport@1.2.0 filesystem 0 271 kB raisedadead
npm/@freecodecamp/react-bootstrap@0.32.3 environment +1 1.62 MB bouncey
npm/@freecodecamp/react-calendar-heatmap@1.1.0 None 0 164 kB mot01
npm/@freecodecamp/strip-comments@3.0.1 None 0 27.2 kB ojeytonwilliams
npm/@growthbook/growthbook-react@0.20.0 Transitive: environment +1 1.76 MB jdorn
npm/@headlessui/react@1.7.18 environment +2 2.68 MB malfaitrobin
npm/@immobiliarelabs/fastify-sentry@7.1.1 Transitive: environment, filesystem, network, shell, unsafe +6 5.13 MB immobiliare-labs-bot
npm/@loadable/component@5.16.3 None +1 323 kB kashey
npm/@playwright/test@1.41.2 None 0 25.3 kB yurys
npm/@prisma/client@5.5.2 environment, filesystem, shell +1 2.12 MB prismabot
npm/@radix-ui/react-tabs@1.0.3 None +14 607 kB benoitgrelard
npm/@reach/router@1.3.4 environment 0 209 kB blainekasten
npm/@redux-saga/core@1.2.2 environment +6 718 kB redux-saga-release-bot
npm/@rollup/plugin-babel@5.3.1 Transitive: environment, filesystem, unsafe +33 12.3 MB shellscape
npm/@rollup/plugin-commonjs@19.0.2 filesystem +2 468 kB shellscape
npm/@rollup/plugin-node-resolve@13.3.0 filesystem +4 4.17 MB shellscape
npm/@rollup/plugin-typescript@8.5.0 environment, filesystem +2 160 kB shellscape
npm/@sentry/node@7.37.1 environment, filesystem, network, shell, unsafe +3 2.81 MB sentry-bot
npm/@sentry/tracing@7.37.1 None +3 2.71 MB sentry-bot
npm/@storybook/addon-a11y@6.5.16 Transitive: environment, eval, network +11 8.82 MB shilman
npm/@storybook/addon-actions@6.5.16 Transitive: environment, eval, network +11 8.76 MB shilman
npm/@storybook/addon-docs@6.5.16 Transitive: environment, eval, filesystem, network, unsafe +92 34.5 MB shilman
npm/@storybook/addon-essentials@6.5.16 Transitive: environment, eval, filesystem, network, unsafe +104 38.8 MB shilman
npm/@storybook/addon-links@6.5.16 Transitive: environment, eval, network +11 2.59 MB shilman
npm/@storybook/addon-postcss@2.0.0 None +2 26.2 kB phated
npm/@storybook/builder-webpack5@6.5.16 environment Transitive: eval, filesystem, network, unsafe +77 32.4 MB shilman
npm/@storybook/manager-webpack5@6.5.16 environment, filesystem, network Transitive: eval, unsafe +79 37.2 MB shilman
npm/@storybook/react@6.5.16 Transitive: environment, eval, filesystem, network, shell, unsafe +108 43.6 MB shilman
npm/@stripe/react-stripe-js@1.16.5 None +1 807 kB pololi-stripe
npm/@stripe/stripe-js@1.54.2 None 0 428 kB madhav-stripe
npm/@testing-library/cypress@9.0.0 Transitive: environment +6 3.32 MB testing-library-bot
npm/@testing-library/dom@8.20.1 environment +5 3.28 MB testing-library-bot
npm/@testing-library/jest-dom@5.17.0 None +4 661 kB testing-library-bot
npm/@testing-library/react@12.1.5 environment +10 7.96 MB testing-library-bot
npm/@testing-library/user-event@14.5.2 Transitive: environment +6 3.72 MB testing-library-bot
npm/@total-typescript/ts-reset@0.5.1 None 0 11.7 kB mpocock
npm/@types/canvas-confetti@1.6.0 None 0 8.8 kB types
npm/@types/chai@4.3.12 None 0 81.3 kB types
npm/@types/codemirror@5.60.15 None +2 219 kB types
npm/@types/copy-webpack-plugin@8.0.1 None +1 3.92 MB types
npm/@types/cors@2.8.17 None +1 4.01 MB types
npm/@types/enzyme-adapter-react-16@1.0.9 None +6 4.23 MB types
npm/@types/enzyme@3.10.16 None +5 4.23 MB types
npm/@types/enzyme@3.10.18 None +5 4.23 MB types
npm/@types/express-session@1.17.10 None +12 4.14 MB types
npm/@types/express@4.17.21 None +11 4.11 MB types
npm/@types/glob@8.0.1 None +2 3.94 MB types
npm/@types/inquirer@8.2.10 None +2 4.08 MB types
npm/@types/jest@29.5.12 None 0 78.7 kB types
npm/@types/jquery@3.5.29 None +1 1.12 MB types
npm/@types/js-yaml@4.0.5 None 0 9.6 kB types
npm/@types/jsonwebtoken@9.0.5 None +1 3.93 MB types
npm/@types/loadable__component@5.13.8 None +3 189 kB types
npm/@types/lodash-es@4.17.12 None +1 934 kB types
npm/@types/lodash-es@4.17.9 None +1 935 kB types
npm/@types/lodash@4.14.202 None 0 862 kB types
npm/@types/node-fetch@2.1.0 None +1 3.92 MB types
npm/@types/nodemailer@6.4.14 None +1 4.01 MB types
npm/@types/prismjs@1.26.0 None 0 19.7 kB types
npm/@types/reach__router@1.3.15 None +3 191 kB types
npm/@types/react-dom@16.9.20 None +3 204 kB types
npm/@types/react-dom@16.9.24 None +3 204 kB types
npm/@types/react-gtm-module@2.0.3 None 0 4.42 kB types
npm/@types/react-helmet@6.1.11 None +3 189 kB types
npm/@types/react-instantsearch-core@6.26.10 None +3 221 kB types
npm/@types/react-instantsearch-dom@6.12.7 None +4 234 kB types
npm/@types/react-redux@7.1.33 None +4 224 kB types
npm/@types/react-responsive@8.0.8 None +3 188 kB types
npm/@types/react-scrollable-anchor@0.6.4 None +3 186 kB types
npm/@types/react-spinkit@3.0.10 None +3 190 kB types
npm/@types/react-test-renderer@16.9.12 None +3 190 kB types
npm/@types/react-transition-group@4.4.10 None +3 201 kB types
npm/@types/react@16.14.56 None +2 182 kB types
npm/@types/redux-actions@2.6.5 None 0 11 kB types
npm/@types/sanitize-html@2.8.0 None 0 8.26 kB types
npm/@types/store@2.0.3 None 0 6.23 kB types
npm/@types/store@2.0.5 None 0 8.29 kB types
npm/@types/supertest@2.0.16 None +3 3.95 MB types
npm/@types/testing-library__jest-dom@5.14.5 None +1 109 kB types
npm/@types/validator@13.7.12 None 0 67.2 kB types
npm/json-server@0.17.4 environment, filesystem Transitive: eval, network, unsafe +102 2.88 MB typicode

🚮 Removed packages: npm/@freecodecamp/ui@0.0.1, npm/ajv-formats@2.1.1, npm/ajv@8.12.0, npm/debug@4.3.4, npm/dotenv@16.4.5, npm/eslint-config-prettier@9.1.0, npm/execa@5.1.1, npm/glob@8.1.0, npm/inquirer@8.2.6, npm/js-yaml@3.14.1, npm/js-yaml@4.0.0, npm/js-yaml@4.1.0, npm/jsonwebtoken@9.0.2, npm/lodash@4.17.21, npm/mocha@10.3.0, npm/node-fetch@2.7.0, npm/prettier@3.2.5, npm/process@0.11.10, npm/readdirp@3.6.0, npm/tslib@2.6.2, npm/util@0.12.5, npm/uuid@8.3.2, npm/yargs@17.7.2

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Feb 26, 2024 •
edited

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@fortawesome/fontawesome-common-types@6.4.2, npm/@fortawesome/fontawesome-svg-core@6.4.2, npm/@fortawesome/free-brands-svg-icons@6.4.2, npm/@fortawesome/free-solid-svg-icons@6.4.2, npm/@prisma/client@5.5.2, npm/@prisma/engines@5.5.2

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@ojeytonwilliams
Copy link
Contributor Author

@SocketSecurity ignore npm/@fortawesome/fontawesome-common-types@6.4.2
@SocketSecurity ignore npm/@fortawesome/fontawesome-svg-core@6.4.2
@SocketSecurity ignore npm/@fortawesome/free-brands-svg-icons@6.4.2
@SocketSecurity ignore npm/@fortawesome/free-solid-svg-icons@6.4.2
@SocketSecurity ignore npm/@prisma/client@5.5.2
@SocketSecurity ignore npm/@prisma/engines@5.5.2

@huyenltnguyen huyenltnguyen added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 26, 2024
@huyenltnguyen
Copy link
Member

global-setup.ts should run before any other tests, but does not if the dependencies are inside e2e/node_modules.

Do you think this is the cause of webkit test failures we had back in Hacktoberfest? It has been bugging me for quite a while now, so it's really great if this change resolves the issue.

@ojeytonwilliams
Copy link
Contributor Author

Do you think this is the cause of webkit test failures we had back in Hacktoberfest?

It probably caused some confusion since users likely didn't realise why (or if) they were authenticated.

Do you remember much about those failures? I can't remember much, to be honest, so I'm not sure if this would have mattered.

@raisedadead raisedadead merged commit 074af6e into freeCodeCamp:main Feb 26, 2024
25 checks passed
@ojeytonwilliams ojeytonwilliams deleted the chore/fix-playwright branch February 26, 2024 17:07
This was referenced Feb 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raisedadead raisedadead raisedadead approved these changes

@huyenltnguyen huyenltnguyen huyenltnguyen approved these changes

Assignees
No one assigned
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ojeytonwilliams @huyenltnguyen @raisedadead