fix(curriculum): enhanced grammer and flexibility in tests to accommodate any valid response

[aaqib605]

Checklist:

• I have read and followed the contribution guidelines.
• I have read and followed the how to open a pull request guide.
• My pull request targets the main branch of freeCodeCamp.
• I have tested these changes either locally on my machine, or GitPod.

Closes #53700

[gikf]

Hey @aaqib605

Thank you for opening this pull request and being eager to contribute.

You have already another PR, which will be merged, for issue limited to the "first time" code contributors to this repository. Let's leave this issue one for other first timers. Because of that I'm going to close this PR. We would welcome future pull requests from you.

Thank you and happy coding.

[aaqib605]

Hey @aaqib605

Thank you for opening this pull request and being eager to contribute.

You have already another PR, which will be merged, for issue limited to the "first time" code contributors to this repository. Let's leave this issue one for other first timers. Because of that I'm going to close this PR. We would welcome future pull requests from you.

Thank you and happy coding.

@gikf I appreciate your consideration and I look forward to contributing in the future.

Thank you again and have a great day!

[srikanth-kandi]

@gikf, I think this is not for first time contributors

Please recheck the issue #53700

[gikf]

Hmm, welp 🤦‍♂️ . You are right @srikanth-kandi, thanks!

@aaqib605 my apologies.

[aaqib605]

@gikf Never mind. Happens to the best of us. Happy to contribute.

[Ksound22]

The second test only passes if the condition is userData?.currentSong === null || userData?.currentSong.id !== song.id.

Can you try and look into that too?

[aaqib605]

The second test only passes if the condition is userData?.currentSong === null || userData?.currentSong.id !== song.id.

Can you try and look into that too?

@Ksound22 Done. Now the tests work for all possible code variations.

[Ksound22]

The second test only passes if the condition is userData?.currentSong === null || userData?.currentSong.id !== song.id.
Can you try and look into that too?

@Ksound22 Done. Now the tests work for all possible code variations.

No. The second test is not reached anymore for the three possible conditions from the issue

[aaqib605]

@Ksound22 Made the necessary changes. It should work fine now.

Hey @aaqib605 👋🏽

The second test is only reached when the condition is exactly userData?.currentSong.id !== song.id || userData?.currentSong === undefined.

I'm looking into what I can do on my end.

[gikf]

@aaqib605 Unfortunately I'm not seeing any new commits on the PR branch: https://github.com/freeCodeCamp/freeCodeCamp/pull/53786/commits

Please make sure they are pushed to the right branch. Join us in our chat room or the forum if you need help with it, our moderators will guide you through this.

[aaqib605]

the forum

@gikf I have asked for help on discord.

However i want to know that my PR branch and my forked repositories' main branche are aligned, and the code is functioning as expected. What might be causing the delay in merging the pull request?

[ilenia-magoni]

What might be causing the delay in merging the pull request?

the pull request is not ready to be merged, you need to make changes to the branch to make the tests work correctly

[aaqib605]

Could you please take a look at the freeCodeCamp discord forum, asked for help there
https://discord.com/channels/692816967895220344/1019641182340534294/threads/1217091995600683139

[aaqib605]

Should i just make a new PR?

[Ksound22]

Should i just make a new PR?

I think you should.

[ilenia-magoni]

Now it works as requested! Sorry for the noise

I have a little point to make:

So userData?.currentSong === undefined should not actually pass

[Ksound22]

Hey @ilenia-magoni 👋🏽

Thanks for requesting I review this again. It's now okay with me. Could you please take a look at it yourself and approve it?

This took a lot of time, so I think it needs an extra eye.

[Ksound22]

Thanks for not giving up on this, @aaqib605!

[ilenia-magoni]

Now it works as requested! Sorry for the noise

I have a little point to make:
undefined === null is false
So userData?.currentSong === undefined should not actually pass

[aaqib605]

Thanks for not giving up on this, @aaqib605!

I would like to thank everybody for their support.

[aaqib605]

Now it works as requested! Sorry for the noise

I have a little point to make: undefined === null is false So userData?.currentSong === undefined should not actually pass

@ilenia-magoni Could you please explain this in more detail, like how it affects the solution?

[ilenia-magoni]

Now it works as requested! Sorry for the noise
I have a little point to make: undefined === null is false So userData?.currentSong === undefined should not actually pass

@ilenia-magoni Could you please explain this in more detail, like how it affects the solution?

The condition for the if statement is to check if userData?.currentSong is null, checking if it is undefined doesn't complete this goal, because if it is null, null === undefined is still false, so you should remove userData?.currentSong === undefined from the accepted solutions. You allow it with this part of the regex userData\?\.currentSong\s*===\s*undefined. That would be removing that section from two places in each test.

[jdwilkin4]

HI @aaqib605 !

It looks like there is one last change requested for this PR left in this comment here
#53786 (comment)

It could make that change, then we should be good to go with this PR 👍

[aaqib605]

HI @aaqib605 !

It looks like there is one last change requested for this PR left in this comment here #53786 (comment)

It could make that change, then we should be good to go with this PR 👍

Thanks, everybody for the patience, I am working to implement this little change.

[ilenia-magoni]

this should be the solution for my last review

[camperbot]

This PR seems to make similar changes as an existing PR. As such, we are going to close this as a duplicate.

If you feel you have additional changes to expand upon this PR, please feel free to push your commits and request this PR be reopened.

Thanks again! 😊

---

If you have any questions, feel free to ask questions on the "Contributors" category on our forum or the contributors chat room.