Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): open completionModal on shortcut #42685

Merged
merged 1 commit into from
Jun 30, 2021
Merged

fix(client): open completionModal on shortcut #42685

merged 1 commit into from
Jun 30, 2021

Conversation

ShaunSHamilton
Copy link
Member

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

Related: #42660 (comment)

@ShaunSHamilton ShaunSHamilton requested a review from a team as a code owner June 30, 2021 14:14
@gitpod-io
Copy link

gitpod-io bot commented Jun 30, 2021

@github-actions github-actions bot added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Jun 30, 2021
@moT01 moT01 mentioned this pull request Jun 30, 2021
Closed
5 tasks
naomi-lgbt
naomi-lgbt approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyboard shortcuts work for me with this PR, running locally.

moT01
moT01 approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@moT01 moT01 merged commit 9d0a7c6 into freeCodeCamp:next Jun 30, 2021
raisedadead pushed a commit to raisedadead/freeCodeCamp that referenced this pull request Jun 30, 2021
@ShaunSHamilton @raisedadead
fix(client): open completionModal on shortcut (freeCodeCamp#42685)
de2f4e2
@ShaunSHamilton ShaunSHamilton deleted the fix/open-modal branch June 30, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShaunSHamilton @moT01 @naomi-lgbt