Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helmet install and csp lessons #40904

Merged
merged 1 commit into from Feb 6, 2021
Merged

fix: helmet install and csp lessons #40904

merged 1 commit into from Feb 6, 2021

Conversation

moT01
Copy link
Member

@moT01 moT01 commented Feb 4, 2021 •
edited

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #39582

I went through the lessons and verified that using ^3.21.3 does not break anything. I couldn't handle the instructions on the CSP lesson - I could not figure out how the sytax of what they were asking should be, so I modified them a little.

@gitpod-io
Copy link

gitpod-io bot commented Feb 4, 2021

naomi-lgbt
naomi-lgbt approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Tested against the current boilerplate, both challenges pass with these instructions.

@naomi-lgbt naomi-lgbt added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Feb 6, 2021
ShaunSHamilton
ShaunSHamilton approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍

@ShaunSHamilton ShaunSHamilton merged commit 15227a0 into freeCodeCamp:main Feb 6, 2021
@moT01 moT01 deleted the fix/helmet-install-specific-version-instructions branch February 6, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunSHamilton ShaunSHamilton ShaunSHamilton approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Are updates to "Install and Require Helmet" challenge needed?
3 participants
@moT01 @ShaunSHamilton @naomi-lgbt