Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum): Remove quotes #35633

Closed

Conversation

thecodingaviator
Copy link
Contributor

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Refer #35481

@RandellDawson
Copy link
Member

Was there a problem in the displaying of those 3 challenges you removed quotes from? I tested master for those 3 challenges and did not see any issues. This seems like a PR which was not needed. In fact, when I tested your PR locally, it creates issues. Those double quotes were needed so that when the double quotes where escaped, they would show as double quotes on the page.

image

image

I am closing this PR, because I can not find there was anything to be fixed in the first place. If you can explain what problem it fixes, we can reopen it.

@thecodingaviator
Copy link
Contributor Author

Nope, on second look, everything seems to be fine. I'm not sure why I was viewing something extra where I was looking at the code, I'll check and get back.

@thecodingaviator
Copy link
Contributor Author

Ohkay, I found the problem, the link I had posted on the issue refers to a user's fork of the fCC repo and not the latest master, that's why I was viewing the discrepancy. You're right in closing it

@thecodingaviator thecodingaviator deleted the fix/Quotes branch March 19, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants