Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: privacy terms page styling issues and jQuery not initialised #18027

Merged

Conversation

Stef733
Copy link

@Stef733 Stef733 commented Aug 19, 2018

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

In /accept-privacy-terms page:

fix:

  1. top positioning of check marks
  2. jQuery not instantiated for script that relies on it

screenshot from 2018-08-19 19-13-56

@raisedadead raisedadead force-pushed the fix/privacy-terms-page-styling-issues branch from b9f0067 to fbc5460 Compare August 22, 2018 16:52
@raisedadead raisedadead merged commit aacd445 into freeCodeCamp:staging Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants