Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(seed/challenges): Renamed em tag challenge #16451

Closed
wants to merge 1 commit into from

Conversation

manuhdez
Copy link

@manuhdez manuhdez commented Jan 9, 2018

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #16448

Description

Renamed challenge "Use the em Tag to Italicize Text" to "Use the em Tag to Emphasize Text" for a better semantic approach.

Copy link
Member

@vkWeb vkWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuhdez Great. It makes much more sense now. Thanks for the PR. 👍
@raisedadead Can we merge this?

Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @manuhdez first of all thanks a lot for taking the time to make this pull request.

However I am of the opinion that changing the title does not resolve the issue that the OP on the original thread as mentioned.

Please continue on the original thread. We will guide further on a proper update to the challenge, post which you can update this request.

@raisedadead raisedadead added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Jan 10, 2018
@BerkeleyTrue
Copy link
Contributor

Closing as stale

@BerkeleyTrue BerkeleyTrue removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Jan 24, 2018
@manuhdez manuhdez deleted the fix/em-semantics branch January 25, 2018 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants