New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(code-editor): Matching-braces Style Changed #16398
Conversation
@vkWeb updated the pull request. |
Closes freeCodeCamp#16363 fix color mismatch
@vkWeb updated the pull request. |
9a36488
to
88cc816
Compare
div.CodeMirror span.CodeMirror-matchingbracket { | ||
border: 0.5px solid #939393 !important; | ||
color: #000; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Hi @vkWeb would you need any help with this, there is a conflict that needs to be resolved, and the review comment to be addressed. Let us know. |
@raisedadead Yes, I need help with this merge conflict. How can I resolve this? And Yes, I'll make the requested changes. Actually, my local environment is down, it's showing that |
You start with rebasing your branch, same as current staging. Follow the rebasing instructions in the docs, except use it on your pr branch. When you get to the conflict, resolve them in your editor. Add your changes, make sure the old change is not overwritten by yours. And push back on this PR branch However, Reachout to the Contributors Chat room for help. |
@raisedadead Thanks for the help - Okay, I'm closing this PR. I'll submit a new one within few days. |
Pre-Submission Checklist
staging
branch of freeCodeCamp.fix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm test
. Usegit commit --amend
to amend any fixes.Type of Change
Checklist:
Reason: Code-mirror doesn't seem to work locally.
Closes #16363
Description
Added a border around the pair of matching braces like in VSCode and also It's uniform with the night mode.
Default Setup:
After applying the changes: