Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "dot operator" to "dot notation" #15794

Merged
merged 1 commit into from Sep 16, 2017

Conversation

Bouzmine
Copy link
Contributor

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Change "dot operator" to "dot notation" as proposed in issue #15646 to be consistent with MDN.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Aug 24, 2017
@freeCodeCamp freeCodeCamp deleted a comment from camperbot Aug 24, 2017
"The dot operator is what you use when you know the name of the property you're trying to access ahead of time.",
"Here is a sample of using the dot operator (<code>.</code>) to read an object's property:",
"There are two ways to access the properties of an object: the dot notation (<code>.</code>) and bracket notation (<code>[]</code>), similar to an array.",
"The dot notation is what you use when you know the name of the property you're trying to access ahead of time.",

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@@ -4198,11 +4198,11 @@
},
{
"id": "56533eb9ac21ba0edf2244c7",
"title": "Accessing Object Properties with the Dot Operator",
"title": "Accessing Object Properties with the Dot Notation",

This comment was marked as off-topic.

@dhcodes
Copy link
Contributor

dhcodes commented Sep 3, 2017

Will you be able to update this @Bouzmine?

@QuincyLarson
Copy link
Contributor

@Bouzmine I'm excited to merge this PR. Can you take a look at @dhcodes's review and make the changes real quick?

@camperbot
Copy link
Contributor

@Bouzmine updated the pull request.

@dhcodes
Copy link
Contributor

dhcodes commented Sep 16, 2017

LGTM. Thanks for updating this @Bouzmine, and thanks for contributing to freeCodeCamp! 👍 💯 🌮 🦅

@dhcodes dhcodes merged commit 4c01621 into freeCodeCamp:staging Sep 16, 2017
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 16, 2017
@QuincyLarson
Copy link
Contributor

@Bouzmine Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants