Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(challenges): Add check for function name in test cases #15681

Conversation

vs1682
Copy link

@vs1682 vs1682 commented Jul 23, 2017

Changed a test case where it checks that the user defined function name
matches to that given in instructions.

BREAKING CHANGE: no breaking change

Closes #15591

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

In issue #15591 user was able to pass a test with function name as glideMixing, but the test case says that

Your code should declare a glideMixin variable that is a function.

This change checks the function name to be exact as given in test case.

Changed a test case where it checks that the user defined function name
matches to that given in instructions.

BREAKING CHANGE: no breaking change

Closes freeCodeCamp#15591
@camperbot
Copy link
Contributor

@vs1682 thanks for the PR.
Do not include issue numbers and following keywords in commit messages.
Please review our Guidelines for Contributing, thank you!

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jul 23, 2017
@Manish-Giri
Copy link
Contributor

This is not the underlying problem here. Refer - ☝️ [July 11, 2017 2:24 PM](https://gitter.im/FreeCodeCamp/Contributors?at=596517f089aea4761d8a9ba4

@vs1682
Copy link
Author

vs1682 commented Jul 23, 2017

@Manish-Giri Sorry my bad. Did you find anything on this?

@vs1682 vs1682 closed this Jul 26, 2017
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jul 26, 2017
@vs1682 vs1682 deleted the fix/check-function-name-for-test-cases branch July 26, 2017 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants