chore(seed): freeCodeCampify remaining sections of codebase #13055

no-stack-dub-sack · 2017-02-02T01:52:31Z

Pre-Submission Checklist

Your pull request targets the staging branch of freeCodeCamp.
Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
You have only one commit (if not, squash them into one commit).
All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)
Add new translation (feature adding new translations)

Checklist:

Tested changes locally.

Description

This PR is a partial completion of issue #12472.

This mainly targets seed files, but I ran a search when I was finished with that directory and found a couple of nagging left over little buggers in other areas of the codebase, so I went ahead and fixed those as well.

I've replaced every instance (visible to the user) of Free Code Camp, free code camp, FreeCodeCamp, freecodecamp, and FREE CODE CAMP with the much more highly desirable freeCodeCamp - except in irrelevant URLs not visible to the user or where required by challenges (ex. regex challenges include other cases in tests). I did hit some URLs (only the ones that we've changed, i.e. github, codepen), and, I even got the issue template!

I did mention in #12472 that I did leave a few instances of freecodecamp in the Twitch challenge, because not sure how the API would interpret the case change. Also, our name has not yet been changed on Twitch, and we may have left that out of the change plan (looks like we're still FreeCodeCampin' over there! 😜 ).

Anyway, one step closer to putting this issue to rest finally!

Greenheart

@no-stack-dub-sack Thanks for the fix! Generally looking good, I'm just unsure about a few parts that might need to be lowercase either to pass tests, or to look nice as printed URL:s ^^

.github/ISSUE_TEMPLATE.md

- 
+
+
+


seed/challenges/02-javascript-algorithms-and-data-structures/basic-javascript.json

@@ -4057,7 +4057,7 @@
        "The above outputs \"Hello\" to the console, returns \"World\", but <code>\"byebye\"</code> is never output, because the function exits at the <code>return</code> statement.",
        "<hr>",
        "Modify the function <code>abTest</code> so that if <code>a</code> or <code>b</code> are less than <code>0</code> the function will immediately exit with a value of <code>undefined</code>.",
-        "<strong>Hint</strong><br>Remember that <a href='http://www.freecodecamp.com/challenges/understanding-uninitialized-variables' target='_blank'><code>undefined</code> is a keyword</a>, not a string."
+        "<strong>Hint</strong><br>Remember that <a href='http://www.freeCodeCamp.com/challenges/understanding-uninitialized-variables' target='_blank'><code>undefined</code> is a keyword</a>, not a string."


seed/challenges/05-apis-and-microservices/basic-node-and-express.json

@@ -234,7 +234,7 @@
        "<code>route_path: '/user/:userId/book/:bookId'</code>",
        "<code>actual_request_URL: '/user/546/book/6754' </code>",
        "<code>req.params: {userId: '546', bookId: '6754'}</code>",
-        "Build an echo server, mounted at the route GET /:word/echo. Respond with a json document, taking the structure {echo: <word>}. You can find the word to be repeated at req.params.word. You can test your route from your browser the address bar, visiting some matching routes, e.g. <your-app-rootpath>/freecodecamp/echo"
+        "Build an echo server, mounted at the route GET /:word/echo. Respond with a json document, taking the structure {echo: <word>}. You can find the word to be repeated at req.params.word. You can test your route from your browser the address bar, visiting some matching routes, e.g. <your-app-rootpath>/freeCodeCamp/echo"


seed/challenges/05-apis-and-microservices/managing-packages-with-npm.json

@@ -97,7 +97,7 @@
        "As you can see, this field is structured as an array of double-quoted strings.",
        "Instructions",
        "Add an array of suitable strings to the keywords-field in the package.json of your HyperDev project.",
-        "One of the keywords should be freecodecamp."
+        "One of the keywords should be freeCodeCamp."


seed/challenges/05-apis-and-microservices/managing-packages-with-npm.json

@@ -110,8 +110,8 @@
          "testString": "getUserInput => $.get(getUserInput('url') + '/_api/package.json').then(data => { var packJson = JSON.parse(data); assert.isArray(packJson.keywords, '\"keywords\" is not an array'); }, xhr => { throw new Error(xhr.responseText); })"
        },
        {
-          "text": "\"keywords\" should include \"freecodecamp\"",
-          "testString": "getUserInput => $.get(getUserInput('url') + '/_api/package.json').then(data => { var packJson = JSON.parse(data);     assert.include(packJson.keywords, 'freecodecamp', '\"keywords\" does not include \"freecodecamp\"'); },  xhr => { throw new Error(xhr.responseText); })"
+          "text": "\"keywords\" should include \"freeCodeCamp\"",


seed/challenges/05-apis-and-microservices/api-and-microservice-projects.json

@@ -22,8 +22,8 @@
        "text": "\"keywords\" field should be an Array",
        "testString": "getUserInput => ($.get(getUserInput('url') + '/_api/package.json').then(function(data){ var packJson = JSON.parse(data); assert.isArray(packJson.keywords); }, err => { throw new Error('Err: ' + err.statusText);}))"
      }, {
-        "text": "\"keywords\" should include \"freecodecamp\"",
-        "testString": "getUserInput => ($.get(getUserInput('url') + '/_api/package.json').then(function(data){ var packJson = JSON.parse(data); assert.include(packJson.keywords, 'freecodecamp'); }, err => { throw new Error('Err: ' + err.statusText); }))"
+        "text": "\"keywords\" should include \"freeCodeCamp\"",


seed/challenges/05-apis-and-microservices/managing-packages-with-npm.json

-          "text": "\"keywords\" should include \"freecodecamp\"",
-          "testString": "getUserInput => $.get(getUserInput('url') + '/_api/package.json').then(data => { var packJson = JSON.parse(data);     assert.include(packJson.keywords, 'freecodecamp', '\"keywords\" does not include \"freecodecamp\"'); },  xhr => { throw new Error(xhr.responseText); })"
+          "text": "\"keywords\" should include \"freeCodeCamp\"",
+          "testString": "getUserInput => $.get(getUserInput('url') + '/_api/package.json').then(data => { var packJson = JSON.parse(data);     assert.include(packJson.keywords, 'freeCodeCamp', '\"keywords\" does not include \"freeCodeCamp\"'); },  xhr => { throw new Error(xhr.responseText); })"


no-stack-dub-sack · 2017-02-02T22:41:28Z

@Greenheart Ok, check it out when you get the chance. Made requested changes! Off to node school for me 😄

Greenheart

Yo gimme some space in the ISSUE_TEMPLATE bro!

.github/ISSUE_TEMPLATE.md

- 
+
+
+


no-stack-dub-sack · 2017-02-02T23:08:38Z

@Greenheart There's 3 new lines between the backticks, no? Not sure why there should be a white space left there? Is there a reason why code shouldn't start at the first character of the new line?

Greenheart · 2017-02-02T23:11:58Z

@no-stack-dub-sack Sorry, I meant a space after the bullets like + |.

In GitHub markdown, there's a difference between using a space or not:

+hello (+hello)

hello (+ hello)

no-stack-dub-sack · 2017-02-02T23:18:51Z

@Greenheart Sure, but this is between sets of ```, in which markdown is not interpreted:

__ignored markdown__

so the only difference between leaving a trailing white space there would be this:

assert(someSuperCoolCode === true, 'message...');

vs.

 assert(someSuperCoolCode === true, 'message...');

Just a white space 😄

I'll change if you'd like, I think perhaps I'm still missing the point though

Edit: Although it does look like the new lines were removed after the screenshot section as well which def should be fixed

Greenheart · 2017-02-02T23:23:30Z

@no-stack-dub-sack OH! Hahaha I interpreted the + signs as bullets in MD...

This is ready 😆

no-stack-dub-sack · 2017-02-02T23:25:38Z

@Greenheart hahaha, I sensed there was a disconnect somewhere! Well, let me just fix the newlines after the screenshot section before you merge

no-stack-dub-sack · 2017-02-02T23:34:21Z

@Greenheart Okie dokie, once travis is done doing his thing, we're good to go. Phwewf!

Travis - who is that guy anyway? Always building things

BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 2, 2017

Greenheart self-requested a review February 2, 2017 02:09

Greenheart approved these changes Feb 2, 2017

View reviewed changes

no-stack-dub-sack force-pushed the fix/chore-seed-freeCodeCampify branch from 2303b04 to 07486be Compare February 2, 2017 22:39

Greenheart suggested changes Feb 2, 2017

View reviewed changes

.github/ISSUE_TEMPLATE.md

This comment was marked as off-topic.

Sign in to view

Greenheart approved these changes Feb 2, 2017

View reviewed changes

no-stack-dub-sack added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Feb 2, 2017

chore(seed): freeCodeCampify remaining sections of codebase

0b60d7d

no-stack-dub-sack force-pushed the fix/chore-seed-freeCodeCampify branch from 07486be to 0b60d7d Compare February 2, 2017 23:31

no-stack-dub-sack removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Feb 2, 2017

Greenheart merged commit 32e3210 into freeCodeCamp:staging Feb 2, 2017

BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 2, 2017

no-stack-dub-sack deleted the fix/chore-seed-freeCodeCampify branch February 2, 2017 23:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(seed): freeCodeCampify remaining sections of codebase #13055

chore(seed): freeCodeCampify remaining sections of codebase #13055

no-stack-dub-sack commented Feb 2, 2017

Greenheart left a comment

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

no-stack-dub-sack commented Feb 2, 2017

Greenheart left a comment

This comment was marked as off-topic.

no-stack-dub-sack commented Feb 2, 2017

Greenheart commented Feb 2, 2017 •

edited

no-stack-dub-sack commented Feb 2, 2017 •

edited

Greenheart commented Feb 2, 2017

no-stack-dub-sack commented Feb 2, 2017

no-stack-dub-sack commented Feb 2, 2017

chore(seed): freeCodeCampify remaining sections of codebase #13055

chore(seed): freeCodeCampify remaining sections of codebase #13055

Conversation

no-stack-dub-sack commented Feb 2, 2017

Pre-Submission Checklist

Type of Change

Checklist:

Description

Greenheart left a comment

Choose a reason for hiding this comment

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

no-stack-dub-sack commented Feb 2, 2017

Greenheart left a comment

Choose a reason for hiding this comment

This comment was marked as off-topic.

no-stack-dub-sack commented Feb 2, 2017

Greenheart commented Feb 2, 2017 • edited

no-stack-dub-sack commented Feb 2, 2017 • edited

Greenheart commented Feb 2, 2017

no-stack-dub-sack commented Feb 2, 2017

no-stack-dub-sack commented Feb 2, 2017

Greenheart commented Feb 2, 2017 •

edited

no-stack-dub-sack commented Feb 2, 2017 •

edited