Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try2:Fixed all the old style Free Code Camp to freeCodeCamp in seed/challenges #12714

Closed
wants to merge 6 commits into from

Conversation

Dazler
Copy link

@Dazler Dazler commented Jan 21, 2017

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 21, 2017
@dhcodes
Copy link
Contributor

dhcodes commented Jan 22, 2017

@Dazler you'll need to rebase your branch with git pull --rebase upstream staging and then push this branch again with -f to get rid of the merge conflicts. Also, in the future, please name your branch something like fix/change-freecodecamp-style.

@raisedadead
Copy link
Member

Refers #12472

@raisedadead
Copy link
Member

@Dazler Hi Avinash, we are closing this, please do not be disheartened, I know this is your first time contributing, and you are doing a good job, but I suggest that you start with a simpler, smaller issue.

This one is a bit complicated, with need for rebasing, merging every now and then as the seed code is being worked upon very frequently.

I think you should do a smaller change that gives you a good idea of the process.

Please reach out to us in the Contributors Chat room, we are super excited to help you!

Thanks a lot and happy fixing!

@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants