Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test case in Increment a Number with JavaScript #12611

Merged
merged 1 commit into from Jan 19, 2017
Merged

Update test case in Increment a Number with JavaScript #12611

merged 1 commit into from Jan 19, 2017

Conversation

AngShiYa
Copy link
Contributor

@AngShiYa AngShiYa commented Jan 19, 2017

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Update test case from "myVar = myVar should be changed" to "myVar = myVar + 1; should be changed"

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 19, 2017
Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ ✨ LGTM. ✨ ✨

Thanks @AngShiYa !

Congratulations on your first PR to freeCodeCamp!

@raisedadead raisedadead merged commit e1fd3b0 into freeCodeCamp:staging Jan 19, 2017
@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 19, 2017
@AngShiYa AngShiYa deleted the fix/test-case-in-basic-js branch January 19, 2017 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants