Changed the word 'swell' to the word 'well' in Basic Javascript challenge #12578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BerkeleyTrue
added
the
status: waiting review
raisedadead
approved these changes
Jan 17, 2017
There was a problem hiding this comment.
✨ ✨ LGTM. ✨ ✨
Thanks @TheeMattOliver and congrats on your first contribution.
Next time, requesting you to have a look at our Guidelines for Contributing and do not add issue nos anywhere other than stated.
In this case the branch name.
raisedadead
removed
the
status: waiting review
|
Lol, was going to say the same @raisedadead. Beat me to it! |
|
@dhcodes 😉..! |
|
@raisedadead @dhcodes Thanks guys. I saw that after I'd pushed....next time, no issue number in branch name. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
stagingbranch of freeCodeCamp.fix/,feature/, ortranslate/(e.g.fix/signin-issue)npm test. Usegit commit --amendto amend any fixes.Type of Change
Checklist:
Description
Changed the word 'swell' to the word 'well' in Basic Javascript challenge "Constructing Strings with Variables." While the usage of 'swell' is probably fine, non-native English speakers may find it less unnatural to use the word 'well', and 'swell' is just uncommon enough in modern usage for 'well' to be a better word choice for native speakers.
All tests passing on local issue branch.