Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(seed): freeCodeCampify challenges: 00, 01, 02) #12561

Conversation

no-stack-dub-sack
Copy link
Member

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • This PR targets feature/curriculum-expansion
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)

Checklist:

  • Tested changes locally.

Description

  • Partial completion of issue Change name from "Free Code Camp" to freeCodeCamp everywhere #12472 - for replacing all instances of "Free Code Camp", "freecodecamp", etc. with "freeCodeCamp" within the codebase.
  • Since the staging brach will be merged/replaced with curriculum expansion anyway, I was advised to perform these updates directly on the feature/curriculum-expansion branch
  • This PR targets instances within the freeCodeCamp/seed/challenges directory. Specifically:
    • 00-getting-started
    • 01-responsive-web-design
    • 02-javascript-algorithms-and-data-structures
  • Where challenge seed or tests was concerned, I replicated the challenges locally to make sure nothing was affected.

Unfortunately, I don't think there is any way to avoid the QA process for these being a nightmare, but for whoever is QAing, let me know if I should go for smaller chunks next time.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 16, 2017
@raisedadead
Copy link
Member

@no-stack-dub-sack

Closing this as discussed, and we can take this on top of #12570 after it has been merged? Thanks a lot. You should wait for staging in that case.

@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 17, 2017
@no-stack-dub-sack
Copy link
Member Author

@raisedadead Yup, that works. No prob, worth doing it over again to have all the new challenges in staging!

@raisedadead
Copy link
Member

Thanks for all the hard work! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants