Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): Updated to server to freeCodeCamp #12501

Closed
wants to merge 1 commit into from
Closed

chore(server): Updated to server to freeCodeCamp #12501

wants to merge 1 commit into from

Conversation

no-stack-dub-sack
Copy link
Member

FCC camelCasing in FreeCodeCamp/server/

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

Partial completion of issue #12472 - for replacing all instances of "Free Code Camp", "freecodecamp", etc. with "freeCodeCamp" within the codebase.

This PR targets all instances within the FreeCodeCamp/server/ directory. There's also replacements in seed/challenges/04-video-challenges/jslingo.json, but from here on out will be targeting one directory per PR. This way QA will hopefully not be too much of a nightmare for this if too much at once is changed.

I tried to update just about anything a user can see and anything else that might be searchable including, email domains (from ...@freecodecamp.com to ...@freeCodeCamp.com), user facing URLs/links, copy, etc., while leaving alone href attributes and instances of freecodecamp in file names, etc. Hopefully this is what was intended. If anything looks wrong, please let me know and I will fix and make a new PR.

fixed cames casing in server/
@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 13, 2017
Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Revert change in the domain name, email.
  2. Exclude the views directory. It has already been changed by a previous PR.

ProTip: git pull --rebase upstream staging before pushing to know if something changed while you were working on it.

Thanks.

@@ -74,8 +74,8 @@ module.exports = function(app) {
var mailOptions = {
type: 'email',
to: user.email,
from: 'Team@freecodecamp.com',
subject: 'Welcome to Free Code Camp!',
from: 'Team@freeCodeCamp.com',

This comment was marked as off-topic.

@@ -56,7 +56,7 @@ export default function({ models }) {
Your GitHub is already associated with another account.
You may have accidentally created a duplicate account.
No worries, though. We can fix this real quick.
Please email us with your GitHub username: team@freecodecamp.com.
Please email us with your GitHub username: team@freeCodeCamp.com.

This comment was marked as off-topic.

@@ -111,8 +111,8 @@ function sendCertifiedEmail(

const notifyTeam = {
type: 'email',
to: 'Michael@FreeCodeCamp.com',
from: 'Team@FreeCodeCamp.com',
to: 'Michael@freeCodeCamp.com',

This comment was marked as off-topic.

to: 'Michael@FreeCodeCamp.com',
from: 'Team@FreeCodeCamp.com',
to: 'Michael@freeCodeCamp.com',
from: 'Team@freeCodeCamp.com',

This comment was marked as off-topic.

@@ -125,7 +125,7 @@ function sendCertifiedEmail(
const notifyUser = {
type: 'email',
to: email,
from: 'Michael@FreeCodeCamp.com',
from: 'Michael@freeCodeCamp.com',

This comment was marked as off-topic.

@@ -238,7 +238,7 @@ export default function certificate(app) {
We need your name so we can put it on your certificate.
<a href="https://github.com/settings/profile">Add your
name to your GitHub account</a>, then go to your
<a href="https://www.freecodecamp.com/settings">settings
<a href="https://www.freeCodeCamp.com/settings">settings

This comment was marked as off-topic.

@raisedadead raisedadead changed the title updated to camel case, several files chore(server): Updated to server to freeCodeCamp Jan 13, 2017
@raisedadead
Copy link
Member

@no-stack-dub-sack and while you are at it:

Can you amend you commit to chore(server): Updated to server to freeCodeCamp which will help us identify the commit to clearly where it changes things. Sorry for this extra step, but you will notice this will help a lot.

@no-stack-dub-sack
Copy link
Member Author

@raisedadead Sounds good, thanks! I will do this this evening

@raisedadead
Copy link
Member

@no-stack-dub-sack thanks you are the rockstar!

@no-stack-dub-sack
Copy link
Member Author

@raisedadead Sorry, but I think I irreparably messed some things up unfortunately... I did a big no-no by accident, and I think I have to start fresh and re-fork the repo. I'm closing this PR - but honestly, not a whole lot lost since the views directory was already done. This will be cleaner once I start over and will do the rest of what's left in the server directory (except for the email domains), then will go on from there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants