Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add MDN Strict Inequality Link #11842

Merged

Conversation

Manish-Giri
Copy link
Contributor

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Modified challenge instruction as recommended. Added an MDN link about strict inequality to the challenge.

I'm not completely sure if I've referenced the MDN link from the MDN Links file the right way in the challenge. Please review the PR and let me know if any changes are required! Thanks!

closes #11763

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 28, 2016
@dhcodes
Copy link
Contributor

dhcodes commented Nov 28, 2016

Tested and LGTM! Now to get those MDN links working...
Thanks for contributing @Manish-Giri 👍 🌮 🎉

@dhcodes dhcodes merged commit 1f105f3 into freeCodeCamp:staging Nov 28, 2016
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 28, 2016
@Manish-Giri Manish-Giri deleted the fix/strict-inequality-operator branch December 3, 2016 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants