Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added word-wrap less rule to .test-output #11715

Conversation

chiptus
Copy link
Contributor

@chiptus chiptus commented Nov 19, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
    By CSS issue with 13" (1280 x 659) viewports. #11687 this should target backup/master
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Added a rule to the .test-output class: word-wrap: break-word.
Closes #11687

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 19, 2016
@ghost ghost closed this Nov 19, 2016
@ghost ghost removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 19, 2016
@systimotic
Copy link
Member

@atjonathan Both pull requests were by @chiptus. As stated (somewhat hidden) in the pre-submission checklist, the issue requested this fix to be submitted against both staging and backup/master. The PR against staging is #11705, this is the PR against backup/master. 😅

@systimotic systimotic reopened this Nov 19, 2016
@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 19, 2016
@raisedadead
Copy link
Member

LGTM. thanks @chiptus

/cc @BerkeleyTrue please release when you have a moment.

@ghost
Copy link

ghost commented Nov 24, 2016

Thanks @chiptus.
@BerkeleyTrue, reminder to release backup/master 😜

@ghost ghost merged commit 292885f into freeCodeCamp:backup/master Nov 24, 2016
@ghost ghost removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 24, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants