Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test for regex challenge #11026

Merged

Conversation

newyork-anthonyng
Copy link
Contributor

@newyork-anthonyng newyork-anthonyng commented Oct 2, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Add more lenient tests for the "Sift through Text with Regular Expressions" challenge.
Included two new regex for tests:
/\band\b/gi
/(?:\b)and(?:\b)/gi

Add more lenient tests for the "Sift through Text with Regular Expressions" challenge.
@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Oct 2, 2016
@dhcodes
Copy link
Contributor

dhcodes commented Oct 3, 2016

Tested locally and works as described. LGTM 👍 Thanks for contributing to freeCodeCamp 🎉

@dhcodes dhcodes merged commit a2c9ae7 into freeCodeCamp:staging Oct 3, 2016
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants