Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of "Filter Arrays with .filter" updated #10730

Merged
merged 1 commit into from Sep 14, 2016
Merged

Description of "Filter Arrays with .filter" updated #10730

merged 1 commit into from Sep 14, 2016

Conversation

theshubhamp-zz
Copy link
Contributor

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Fixes issue #10695
The description of the challenge "Filter Arrays with .filter" was updated to remove double negatives from the description as pointed out in the issue #10695

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 14, 2016
@dhcodes
Copy link
Contributor

dhcodes commented Sep 14, 2016

@Shubham1996 Can you amend this to make the beginning of the sentence be The <code>filter</code> method...

Sorry for not being more explicit in the issue thread. Otherwise, looks good.

@theshubhamp-zz
Copy link
Contributor Author

Yeah, Sure 👍

@camperbot
Copy link
Contributor

@Shubham1996 updated the pull request.

Fixes issue #10695
The description of the challenge "Filter Arrays with .filter" was updated to remove double negatives from the description as pointed out in the issue #10695
@camperbot
Copy link
Contributor

@Shubham1996 updated the pull request.

@theshubhamp-zz
Copy link
Contributor Author

I have updated the Pull Request.

Sorry for the previous pull request btw, I didn't amend the commit and realized it later. 😄

@dhcodes dhcodes merged commit c9054a2 into freeCodeCamp:staging Sep 14, 2016
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 14, 2016
@dhcodes
Copy link
Contributor

dhcodes commented Sep 14, 2016

No worries, I do that all the time. Look gtg to me @Shubham1996

Thanks for contributing! 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants