Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow space on function argument to pass test case #10464

Merged

Conversation

ivantedja
Copy link
Contributor

@ivantedja ivantedja commented Sep 4, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

challenge: Get JSON with the jQuery getJSON Method

@camperbot
Copy link
Contributor

@ivantedja thanks for the PR.
Do not include issue numbers and following keywords in commit messages.
Please, review our Guidelines for Contributing, thank you!.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 4, 2016
challenge: Get JSON with the jQuery getJSON Method
@camperbot
Copy link
Contributor

@ivantedja updated the pull request.

@ivantedja ivantedja force-pushed the fix/allow-space-on-function-argument branch from c472074 to f00f413 Compare September 4, 2016 09:49
@ltegman
Copy link
Member

ltegman commented Sep 7, 2016

Wow, I can see why this error slipped through -- this test is a dizzying mess of regex! Thanks for the fix!

@ltegman ltegman merged commit fb47006 into freeCodeCamp:staging Sep 7, 2016
@ltegman ltegman removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 7, 2016
@ivantedja ivantedja deleted the fix/allow-space-on-function-argument branch September 15, 2016 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants