Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/added description for form controls #10352

Closed
wants to merge 4 commits into from
Closed

Feature/added description for form controls #10352

wants to merge 4 commits into from

Conversation

chakrihacker
Copy link

@chakrihacker chakrihacker commented Aug 26, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

@camperbot
Copy link
Contributor

@chakrihacker thanks for the PR.
You have pushed more than one commit. When you finish editing, squash your commits into one.
Please, review our Guidelines for Contributing, thank you!.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Aug 26, 2016
@ghost
Copy link

ghost commented Aug 28, 2016

@chakrihacker, unfortunately #10320 was published before yours. Don't get discouraged, if the snyk fix is correct, feel free to open a separate PR with the change 😃

@ghost ghost closed this Aug 28, 2016
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Aug 28, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants