Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding description for .form-control (Challenge: Style text inputs as form controls) #10330

Merged

Conversation

n-white
Copy link
Contributor

@n-white n-white commented Aug 24, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Adding an extra line of information to describe what adding the form-control class to the input field actually does.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Aug 24, 2016
@ghost ghost changed the title Adding description for form-controls (issue: #10320) Adding description of .form-control in Style text inputs as form controls Aug 24, 2016
@ghost ghost changed the title Adding description of .form-control in Style text inputs as form controls Adding description for .form-control (Challenge: Style text inputs as form controls) Aug 24, 2016
@ghost
Copy link

ghost commented Aug 28, 2016

✨ ✨ LGTM 👍 ✨ ✨

🎉 Thanks for contributing @n-white and congratulations on your first PR submission to FreeCodeCamp!

@ghost ghost merged commit b71c6d4 into freeCodeCamp:staging Aug 28, 2016
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Aug 28, 2016
@n-white n-white deleted the feature/adding-description-for-form-controls branch February 16, 2017 02:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants