Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are updates to "Install and Require Helmet" challenge needed? #39582

Closed
lasjorg opened this issue Sep 15, 2020 · 8 comments · Fixed by #40904
Closed

Are updates to "Install and Require Helmet" challenge needed? #39582

lasjorg opened this issue Sep 15, 2020 · 8 comments · Fixed by #40904
Labels
help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.

Comments

@lasjorg
Copy link
Contributor

lasjorg commented Sep 15, 2020

Challenge:
https://www.freecodecamp.org/learn/information-security/information-security-with-helmetjs/install-and-require-helmet
https://github.com/freeCodeCamp/freeCodeCamp/blob/master/curriculum/challenges/english/09-information-security/information-security-with-helmetjs/install-and-require-helmet.english.md

  1. Does this challenge need instructions on how to actually install the specified version? On repl.it if you search for a package it will just give you the latest version.

  2. If you run npm i helmet@3.21.3 it will add the package with the caret ^ in front of the version number but the test does not allow for that. Should the test allow for the caret?

@lasjorg lasjorg added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels Sep 15, 2020
@ShaunSHamilton
Copy link
Member

If changing the tests to allow ^ does not cause any of the versioning issues mentioned previously, then we should go with that. Otherwise, we could add a note that the camper should use --save-exact: npm install --save-exact helmet@3.21.3

@ShaunSHamilton
Copy link
Member

Just bringing this back up: Are we changing the tests, or changing the instructions to be explicit about the versioning?

@lasjorg
Copy link
Contributor Author

lasjorg commented Nov 14, 2020

Personally, I'd say both.

Show the npm command for how to install a specific package version and make the test ignore/accept the caret.

@ShaunSHamilton
Copy link
Member

@lasjorg I like that. This kind of lesson is so short, I also think it would be useful to add the information about --save-exact.

I am going to open this up for general help

@ShaunSHamilton ShaunSHamilton added help wanted Open for all. You do not need permission to work on these. and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels Nov 14, 2020
@flemmingbond21
Copy link

Hi, I do exactly like npm install --save-exact helmet@3.21.3 and helmet = require('helmet'); but still not pass the challenge, anyone, please help me, thanks

@ShaunSHamilton
Copy link
Member

Hey @flemmingbond21 ,

Without seeing your code, or being able to test your project, it will be difficult to assist.

Please make use of the forum to open a topic, and provide as much detail as possible. It will be easier to assist that way.

@flemmingbond21
Copy link

my code:
myapp.js:
var express = require('express');
var app = express();
const helmet = require('helmet');
package.json:
{
"name": "fcc-infosec-challenges",
"version": "0.0.1",
"description": "fcc backend boilerplate",
"main": "server.js",
"scripts": {
"start": "node myApp.js"
},
"dependencies": {
"express": "^4.14.0",
"helmet": "3.21.3"
},
"keywords": [
"node",
"hyperdev",
"express",
"freecodecamp"
],
"license": "MIT"
}
and the test result:

// running tests
helmet version 3.21.3 should be in package.json
// tests completed
Please help me to solve this. thanks

@RandellDawson
Copy link
Member

@flemmingbond21 As @ShaunSHamilton mentioned, please use our forum for questions that involve debugging challenge or project solutions. Thank you.

ps428 added a commit to ps428/boilerplate-infosec that referenced this issue Jul 1, 2021
ps428 added a commit to ps428/boilerplate-infosec that referenced this issue Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants