Fix for rare issues on iOS with reading binary data #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys with a shared buffer. This solves rare issues seen on iOS where read values would be NaN, perhaps due to endianness. It seems to give a slight performance increase in some cases as well.
|
Looks like DataView has been around almost as long as TypedArrays (except some of the 64-bit functions), so it should be safe. Good change, I like it. Let me just run it in my projects for testing, to make sure nothing has changed before I merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this issue for background. Certain conditions in iOS can sometimes cause the
Typr._binread functions to returnNaN.The culprit, for whatever reason, is the use of TypedArrays with a shared buffer to read the binary datatypes. It's possible that it has something to do with endianness and certain JIT modes on iOS. Regardless, switching to use
DataViewsolves the issue, and seems to improve performance in some cases too.(I'm treating this fork as the new source of truth for pre-Harfbuzz Typr, so I'm submitting this PR here.)