Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow navigating to Table MultiSelect fields using tab (backport #26401) #26405

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 10, 2024

It was skipped earlier as it was part of no_value_type and didn't have an exception added like Table

Reference: support ticket 14690


This is an automatic backport of pull request #26401 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner May 10, 2024 13:06
@mergify mergify bot added the conflicts label May 10, 2024
@mergify mergify bot requested review from ankush and removed request for a team May 10, 2024 13:06
Copy link
Contributor Author

mergify bot commented May 10, 2024

Cherry-pick of 7d27602 has failed:

On branch mergify/bp/version-14-hotfix/pr-26401
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 7d27602c07.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/public/js/frappe/form/layout.js

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

It was skipped earlier as it was part of `no_value_type` and didn't have an exception added like `Table`

(cherry picked from commit 7d27602)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
@akhilnarang akhilnarang force-pushed the mergify/bp/version-14-hotfix/pr-26401 branch from d8a41e0 to 1e5faff Compare May 10, 2024 13:09
@akhilnarang akhilnarang merged commit 86368d0 into version-14-hotfix May 10, 2024
9 of 11 checks passed
@akhilnarang akhilnarang deleted the mergify/bp/version-14-hotfix/pr-26401 branch May 10, 2024 13:29
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.74.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants