fix: pass user and shared params when checking for cache keys (backport #26402) #26403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix: pass user and shared params when checking for cache keys * chore(test): added test for user cache in redis_cache (cherry picked from commit fb2753f) # Conflicts: # frappe/tests/test_caching.py # frappe/utils/caching.py
|
Cherry-pick of fb2753f has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
ankush
force-pushed
the
mergify/bp/version-14-hotfix/pr-26402
branch
from
b50398a
to
af9920f
Compare
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 22, 2024
# [14.75.0](v14.74.1...v14.75.0) (2024-05-22) ### Bug Fixes * "Not assigned" filter (backport [#26468](#26468)) ([#26469](#26469)) ([6bb3534](6bb3534)) * condition of event participants ([#26300](#26300)) ([#26455](#26455)) ([d940902](d940902)) * **contact list:** add space before designation ([a67ebab](a67ebab)) * Don't fiddle with child table indexes ([#26450](#26450)) ([#26452](#26452)) ([d0d6d93](d0d6d93)) * **DX:** Don't run CI if there are no tests (backport [#26457](#26457)) ([#26465](#26465)) ([d129c01](d129c01)) * enable fetch_from for Time fieldtype ([#25266](#25266)) ([#26471](#26471)) ([#26485](#26485)) ([9cd3bf6](9cd3bf6)) * **grid_row:** don't crash when undefined ([0f91073](0f91073)) * Ignore link doctype in comments ([#26484](#26484)) ([910d4a7](910d4a7)) * pass user and shared params when checking for cache keys ([#26402](#26402)) ([#26403](#26403)) ([30799f7](30799f7)) * preserve checked items after a search ([ae9cdd2](ae9cdd2)) ### Features * what's new (v15 port of [#21014](#21014)) (backport [#25986](#25986)) ([#26494](#26494)) ([6a561d9](6a561d9)) ### Performance Improvements * num2words, babel, gettext, sentry imports (backport [#26475](#26475)) ([#26476](#26476)) ([ea873fd](ea873fd))
|
🎉 This PR is included in version 14.75.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User specific cache for
redis_cachedecorator was not working.When checking for cache key existence, the
userandsharedparams were not being passed to theexistsfunction.cc: @ankush
This is an automatic backport of pull request #26402 done by Mergify.