New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: address autocomplete dialog #26395
base: develop
Are you sure you want to change the base?
Conversation
Hey @barredterra, nice work here! I've done some work with geolocation integrations in my Customer Information System Enhancements for ERPNext app. I appreciate the concept of pushing more geolocation integrations upstream, and would be glad to pitch in if possible. In thinking along these lines, perhaps it would be fitting to name your new settings Doctype "Geolocation Settings" instead of "Address Autocomplete Settings", with the goal of integrating providers for address geocoding as well as autocomplete. |
@batonac since Geoapify also offers these other Geolocation features, which could be easily added to our integration, I think your proposal makes sense. I'm not sure about other providers. Maybe at some point it will make more sense to have one settings page per provider. |
a3f163c
to
3933725
Compare
Nice to see this in Frappe Framework. I have both features running in a private app using HERE Map services. Happy to contribute, if you are interested. |
address_autocomplete.mov
Providers:
Todo:
Note: Nomatim must be self-hosted. Using the public service for autocompletion is not allowed.