Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade fullcalendar #26360

Merged
merged 8 commits into from May 13, 2024
Merged

Conversation

rutwikhdev
Copy link
Contributor

@rutwikhdev rutwikhdev commented May 7, 2024

  • remove vendoring
  • upgrade api from v3 to v6
  • feature parity
    • toolbar navigation
    • replace momentjs with native datetime
    • create events - drag, click on date
    • resize events
  • fix css and styling

no-docs

@rutwikhdev rutwikhdev linked an issue May 9, 2024 that may be closed by this pull request
@rutwikhdev rutwikhdev force-pushed the upgrade-fullcalendar branch 2 times, most recently from 4fade27 to be0c912 Compare May 9, 2024 15:18
@rutwikhdev rutwikhdev marked this pull request as ready for review May 9, 2024 15:19
@rutwikhdev rutwikhdev requested a review from a team as a code owner May 9, 2024 15:19
@rutwikhdev rutwikhdev requested review from akhilnarang and removed request for a team May 9, 2024 15:19
@ankush
Copy link
Member

ankush commented May 10, 2024

@rutwikhdev you forgot to update yarn lock

yarn.lock Outdated Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
feature parity for,
- toolbar actions
- show/hide weekend
- navigate through calendar and click events
- move from momentjs to native date api
- simplify selection logic
@ankush ankush merged commit 49fb60a into frappe:develop May 13, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fullcalendar (library behind calendar compoenent)
3 participants