fix: lstrip for query writes detection (backport #26180) #26253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem with the write detection for
frappe.db.sql
This PR should be backported to v14 and v15
This PR comes to solve a problem where a write operation is not detected because of the way it is formatted. A common way to formate a query is the following:
And this method of detecting writes was not working (and leaded us to a 2hs debug session of why the endpoint was not doing a commit in the
after_request
method)This is an automatic backport of pull request #26180 done by [Mergify](https://mergify.com).