fix: compute modal title server side (backport #26179) #26192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 33d59d6)
This comment was marked as outdated.
This comment was marked as outdated.
barredterra
approved these changes
May 15, 2024
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 22, 2024
# [15.28.0](v15.27.0...v15.28.0) (2024-05-22) ### Bug Fixes * "Not assigned" filter ([#26468](#26468)) ([#26470](#26470)) ([ee6545b](ee6545b)) * compute modal title server side ([#26192](#26192)) ([3b787ac](3b787ac)) * condition of event participants ([#26300](#26300)) ([#26456](#26456)) ([31be0b9](31be0b9)) * default tree view ([07883a7](07883a7)) * Don't fiddle with child table indexes ([#26450](#26450)) ([#26453](#26453)) ([7e0d734](7e0d734)) * **DX:** Don't run CI if there are no tests (backport [#26457](#26457)) ([#26466](#26466)) ([72c693e](72c693e)) * enable fetch_from for Time fieldtype ([#25266](#25266)) ([#26471](#26471)) ([#26483](#26483)) ([f1267ca](f1267ca)) * **grid_row:** don't crash when undefined ([116ba1c](116ba1c)) * preserve checked items after a search ([befcce1](befcce1)) ### Features * **recorder:** Suggest index for optimizing query (backport [#26433](#26433)) ([#26435](#26435)) ([4b780cd](4b780cd)) ### Performance Improvements * num2words, babel, gettext, sentry imports ([#26475](#26475)) ([#26477](#26477)) ([e79e5f9](e79e5f9))
|
🎉 This PR is included in version 15.28.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contact form shows a modal telling the user that the message was sent successfully.
The success message was computed on the server side, while the title was computed on the client side. This led to inconsistent translations.
This PR fixes this by computing the title on the server side as well.
This is an automatic backport of pull request #26179 done by Mergify.