fix: compute modal title server side (backport #26179) #26191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
@Mergifyio rebase |
(cherry picked from commit 33d59d6)
✅ Branch has been successfully rebased |
ankush
force-pushed
the
mergify/bp/version-14-hotfix/pr-26179
branch
from
1fe4039
to
a05dcc6
Compare
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
# [14.73.0](v14.72.0...v14.73.0) (2024-04-30) ### Bug Fixes * 🐛 don't create __init__.py files when gathering pages ([#26045](#26045)) ([#26090](#26090)) ([84fbc40](84fbc40)), closes [#25167](#25167) * add missing impl for is_column_missing (backport [#26225](#26225)) ([#26226](#26226)) ([b5abe55](b5abe55)) * allow setting dynamic filters for number cards even without developer mode ([7d5b443](7d5b443)) * avoid perm error on dashboard chart ([#26150](#26150)) ([#26156](#26156)) ([6231e1d](6231e1d)) * calendar in Arabic (backport [#26213](#26213)) ([#26215](#26215)) ([67530e3](67530e3)), closes [#26207](#26207) * compute modal title server side ([#26191](#26191)) ([760ff72](760ff72)) * Dirty form when grid rows are moved ([#26230](#26230)) ([#26233](#26233)) ([ce4fa2a](ce4fa2a)) * filter select perm in get_doctypes_with_read (backport [#26037](#26037)) ([#26039](#26039)) ([e889691](e889691)) * frappe.template.compile(...) is not a function ([#26125](#26125)) ([#26126](#26126)) ([ea5d7b7](ea5d7b7)) * german translations ([#26219](#26219)) ([a40dfdd](a40dfdd)) * **grid_row:** check child table dependent properties whenever a row is selected ([caabb79](caabb79)) * **grid:** ensure that `doc` itself is not null ([a2b61eb](a2b61eb)), closes [#25800](#25800) * handle case where mimetype is None ([#26131](#26131)) ([#26132](#26132)) ([cc3b654](cc3b654)) * handle null in CSV preview ([#26154](#26154)) ([2e2649b](2e2649b)) * register faulthandler on true stderr only (backport [#26028](#26028)) ([#26033](#26033)) ([45630fe](45630fe)) * rename fields for html, col, section, etc. ([#26188](#26188)) ([1a2411c](1a2411c)) * Renaming when doctype is used as a virtual link docfield fails ([#26025](#26025)) ([#26118](#26118)) ([eea6509](eea6509)) * **report builder:** responsive footer ([#26222](#26222)) ([#26223](#26223)) ([4f0bcf1](4f0bcf1)) * **report_utils:** ensure that delimiter and separator can't be empty ([5301516](5301516)) * **report_view:** allow exporting all rows even if count is disabled ([c0cf52f](c0cf52f)) * retry count per doc instead of global ([#26159](#26159)) ([#26160](#26160)) ([0d6ff95](0d6ff95)) * strip redirect URIs for trailing whitespaces ([#26006](#26006)) ([#26007](#26007)) ([aefc6f9](aefc6f9)) * unknown charset windows-874 problem on incoming mail ([86eff33](86eff33)) * **UX:** warning when printing unsaved documents ([#26229](#26229)) ([#26231](#26231)) ([1530618](1530618)) * web form filtering ([#26122](#26122)) ([#26123](#26123)) ([519fec5](519fec5)) ### Features * enable dynamic filters for standard number cards ([3a4eeb9](3a4eeb9)) * **grid:** Add shift-click for selecting multiple rows ([c9d227a](c9d227a)) * **grid:** Extend clickable area of checkboxes ([2664cf3](2664cf3)) * let users unlock stuck documents (backport [#24782](#24782)) ([#25225](#25225)) ([e58ea03](e58ea03)) * limit oauth client to roles (backport [#26193](#26193)) ([#26195](#26195)) ([5b7bccf](5b7bccf))
|
🎉 This PR is included in version 14.73.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contact form shows a modal telling the user that the message was sent successfully.
The success message was computed on the server side, while the title was computed on the client side. This led to inconsistent translations.
This PR fixes this by computing the title on the server side as well.
This is an automatic backport of pull request #26179 done by Mergify.