fix(server): TreeView lookup in DB should perform the same preperation operations …

[fixundfertig123]

…as method update_nsm in file nestedset.py

Symptoms:
DB error when using tree view for custom doctypes, which names contain hyphens, underscores or spaces.

Reason:
Method "update_nsm" in file frappe/utils/nestedset.py builds SQL DB fields according to certain logic, see

frappe/frappe/utils/nestedset.py

Line 44 in 71dfffa

parent_field = "parent_" + frappe.scrub(doc.doctype)

For frappe.scrub see:

frappe/frappe/__init__.py

Lines 1515 to 1517 in 71dfffa

	def scrub(txt: str) -> str:
	"""Return sluggified string. e.g. `Sales Order` becomes `sales_order`."""
	return cstr(txt).replace(" ", "_").replace("-", "_").lower()

However, method "_get_children" in frappe/desk/treeview.py uses another methodology to lookup the data in the database, see

frappe/frappe/desk/treeview.py

Line 46 in 71dfffa

parent_field = "parent_" + doctype.lower().replace(" ", "_")

Example for different conversion:
Doctype name: "AAA-BBB-CCC"
method "update_nsm": "AAA-BBB-CCC" --> "parent_aaa_bbb_ccc"
method "_get_children": "AAA-BBB-CCC" --> "parent_aaa-bbb-ccc"

Resolution:
Updated method "_get_children" in frappe/desk/treeview.py to use same methodology of frappes "on-board resources".

Also created fix for ERPNext: See frappe/erpnext#41221

[fixundfertig123]

Replaced by another pull

[fixundfertig123]

Replaced by another pull request to fix commit naming issues