fix: multistep webform page navigation #26172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilnarang
approved these changes
Apr 29, 2024
rutwikhdev
added
backport version-14-hotfix
This was referenced Apr 29, 2024
rutwikhdev
added a commit
that referenced
this pull request
Apr 29, 2024
…-26172 fix: multistep webform page navigation (backport #26172)
akhilnarang
added a commit
that referenced
this pull request
Apr 30, 2024
…-26172 fix: multistep webform page navigation (backport #26172)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Problem:
Consider a webform with 3 pages. The pages will have the following classes,
p1: form-page
p2: form-page page-break
p3: form-page page-break
form-pageis used for selecting pages for navigation.If any one of these pages have a child table entry the view will be broken because the child-table-edit dialog uses the same layout component as webform and hence when it's rendered the components with form-page as class are duplicated multiple times. So on hitting the edit button for child table the pages would look something like this,
p1: form-page
form-page (child table)
form-page (child table)
...
p2: form-page page-break
p3: form-page page-break
Fix: Using
page-breakclassname(since page-break is unique for webform pages) for navigation between pages (the first page is still form-page, since there is no page-break before that)