refactor!: override_doctype -> Must extend base class #26152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
ankush
force-pushed
the
extend_not_override
branch
from
e3473f9
to
46b54b7
Compare
|
Would it still be possible to do a stupid override with the following code? (but then this would be actively malicious) class Customer:
pass # 😈
class MyCustomerOverride(Customer):
def load_from_db(self):
pass |
Yes, this just reduces EXTREMELY stupid ones like "I didn't like that method so I created entire new class without that method" I've seen people copy entire files 💩 As long as we use python, stupidity is never 100% preventable. Everything is patchable at runtime. |
What does this have to do with hostname?
ankush
force-pushed
the
extend_not_override
branch
from
46b54b7
to
5d5ebc3
Compare
There is almost never a real need to completely override a class. After this change we'll only allow extending and not overriding completely.
ankush
force-pushed
the
extend_not_override
branch
from
5d5ebc3
to
a8ce3c3
Compare
ankush
added
do not backport
and removed
add-test-cases
maharshivpatel
added a commit
to maharshivpatel/frappe
that referenced
this pull request
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is almost never a real need to completely override a class. After
this change we'll only allow extending and not overriding completely.
This feature is abused to create some extremely stupid overrides.