Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v14 #26114

Closed
wants to merge 38 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
c9d227a
feat(grid): Add shift-click for selecting multiple rows
cogk Aug 24, 2023
2664cf3
feat(grid): Extend clickable area of checkboxes
cogk Aug 24, 2023
a8be36f
Merge pull request #25977 from frappe/mergify/bp/version-14-hotfix/pr…
barredterra Apr 17, 2024
eac07b2
chore: bump sqlparse to v0.5.0 (#25976)
barredterra Apr 17, 2024
aefc6f9
fix: strip redirect URIs for trailing whitespaces (#26006) (#26007)
mergify[bot] Apr 17, 2024
e58ea03
feat: let users unlock stuck documents (backport #24782) (#25225)
mergify[bot] Mar 4, 2024
71efa95
chore: resolve conflicts
akhilnarang Apr 18, 2024
c555920
build: bump gunicorn (backport #25980) (#26035)
mergify[bot] Apr 18, 2024
45630fe
fix: register faulthandler on true stderr only (backport #26028) (#26…
mergify[bot] Apr 18, 2024
3217204
Merge pull request #26032 from frappe/mergify/bp/version-14-hotfix/pr…
akhilnarang Apr 18, 2024
c0cf52f
fix(report_view): allow exporting all rows even if count is disabled
akhilnarang Apr 18, 2024
7f11100
Merge pull request #26042 from frappe/mergify/bp/version-14-hotfix/pr…
akhilnarang Apr 18, 2024
caabb79
fix(grid_row): check child table dependent properties whenever a row …
akhilnarang Apr 19, 2024
a3fb044
Merge pull request #26067 from frappe/mergify/bp/version-14-hotfix/pr…
akhilnarang Apr 20, 2024
3a4eeb9
feat: enable dynamic filters for standard number cards
akhilnarang Apr 22, 2024
8a4e219
Merge pull request #26080 from frappe/mergify/bp/version-14-hotfix/pr…
akhilnarang Apr 22, 2024
7d5b443
fix: allow setting dynamic filters for number cards even without deve…
akhilnarang Apr 22, 2024
ddae585
Merge pull request #26082 from frappe/mergify/bp/version-14-hotfix/pr…
akhilnarang Apr 22, 2024
86eff33
fix: unknown charset windows-874 problem on incoming mail
kittiu Apr 17, 2024
bb2c934
refactor: don't modify email library's dictionary
akhilnarang Apr 19, 2024
84fbc40
fix: 🐛 don't create __init__.py files when gathering pages (#26045) …
mergify[bot] Apr 22, 2024
a2b61eb
fix(grid): ensure that `doc` itself is not null
akhilnarang Apr 22, 2024
6d3df38
Merge pull request #26096 from frappe/mergify/bp/version-14-hotfix/pr…
akhilnarang Apr 22, 2024
d6a714a
chore: resolve conflicts
akhilnarang Apr 22, 2024
9ce8fa0
Merge pull request #26087 from frappe/mergify/bp/version-14-hotfix/pr…
akhilnarang Apr 22, 2024
66f80a2
refactor: web form link logic (backport #25951) (#25993)
mergify[bot] Apr 22, 2024
dd48f67
build: bump datatable and report row limit (#26103)
ankush Apr 22, 2024
ff1036a
Revert "fix(grid_row): check child table dependent properties wheneve…
mergify[bot] Apr 23, 2024
519fec5
fix: web form filtering (#26122) (#26123)
mergify[bot] Apr 23, 2024
ea5d7b7
fix: frappe.template.compile(...) is not a function (#26125) (#26126)
mergify[bot] Apr 23, 2024
eea6509
fix: Renaming when doctype is used as a virtual link docfield fails (…
mergify[bot] Apr 23, 2024
cc3b654
fix: handle case where mimetype is None (#26131) (#26132)
mergify[bot] Apr 23, 2024
5a73fd8
refactor: filters for export on prepared report (backport #26106) (#2…
mergify[bot] Apr 24, 2024
0d6ff95
fix: retry count per doc instead of global (#26159) (#26160)
mergify[bot] Apr 25, 2024
fda0edc
chore: drop flaky UI tests (#26144)
ankush Apr 25, 2024
1a2411c
fix: rename fields for html, col, section, etc. (#26188)
Nihantra-Patel Apr 29, 2024
6231e1d
fix: avoid perm error on dashboard chart (#26150) (#26156)
mergify[bot] Apr 29, 2024
a40dfdd
fix: german translations (#26219)
barredterra Apr 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
37 changes: 0 additions & 37 deletions cypress/integration/control_attach.js
Expand Up @@ -19,43 +19,6 @@ context("Attach Control", () => {
});
});
});
it('Checking functionality for "Link" button in the "Attach" fieldtype', () => {
//Navigating to the new form for the newly created doctype
cy.new_form("Test Attach Control");

//Clicking on the attach button which is displayed as part of creating a doctype with "Attach" fieldtype
cy.findByRole("button", { name: "Attach" }).click();

//Clicking on "Link" button to attach a file using the "Link" button
cy.findByRole("button", { name: "Link" }).click();
cy.findByPlaceholderText("Attach a web link").type(
"https://wallpaperplay.com/walls/full/8/2/b/72402.jpg"
);

//Clicking on the Upload button to upload the file
cy.intercept("POST", "/api/method/upload_file").as("upload_image");
cy.get(".modal-footer").findByRole("button", { name: "Upload" }).click({ delay: 500 });
cy.wait("@upload_image");
cy.findByRole("button", { name: "Save" }).click();

//Checking if the URL of the attached image is getting displayed in the field of the newly created doctype
cy.get(".attached-file > .ellipsis > .attached-file-link")
.should("have.attr", "href")
.and("equal", "https://wallpaperplay.com/walls/full/8/2/b/72402.jpg");

//Clicking on the "Clear" button
cy.get('[data-action="clear_attachment"]').click();

//Checking if clicking on the clear button clears the field of the doctype form and again displays the attach button
cy.get(".control-input > .btn-sm").should("contain", "Attach");

//Deleting the doc
cy.go_to_list("Test Attach Control");
cy.get(".list-row-checkbox").eq(0).click();
cy.get(".actions-btn-group > .btn").contains("Actions").click();
cy.get('.actions-btn-group > .dropdown-menu [data-label="Delete"]').click();
cy.click_modal_primary_button("Yes");
});

it('Checking functionality for "Library" button in the "Attach" fieldtype', () => {
//Navigating to the new form for the newly created doctype
Expand Down
37 changes: 1 addition & 36 deletions cypress/integration/file_uploader.js
Expand Up @@ -10,6 +10,7 @@ context("FileUploader", () => {
.then((frappe) => {
new frappe.ui.FileUploader();
});
cy.wait(1000);
}

it("upload dialog api works", () => {
Expand Down Expand Up @@ -47,40 +48,4 @@ context("FileUploader", () => {
.should("have.property", "file_name", "example.json");
cy.get(".modal:visible").should("not.exist");
});

it("should accept web links", () => {
open_upload_dialog();

cy.get_open_dialog().findByRole("button", { name: "Link" }).click();
cy.get_open_dialog()
.findByPlaceholderText("Attach a web link")
.type("https://github.com", { delay: 100, force: true });
cy.intercept("POST", "/api/method/upload_file").as("upload_file");
cy.get_open_dialog().findByRole("button", { name: "Upload" }).click();
cy.wait("@upload_file")
.its("response.body.message")
.should("have.property", "file_url", "https://github.com");
cy.get(".modal:visible").should("not.exist");
});

it("should allow cropping and optimization for valid images", () => {
open_upload_dialog();

cy.get_open_dialog()
.find(".file-upload-area")
.selectFile("cypress/fixtures/sample_image.jpg", {
action: "drag-drop",
});

cy.get_open_dialog().findAllByText("sample_image.jpg").should("exist");
cy.get_open_dialog().find(".btn-crop").first().click();
cy.get_open_dialog().findByRole("button", { name: "Crop" }).click();
cy.get_open_dialog().findAllByRole("checkbox", { name: "Optimize" }).should("exist");
cy.get_open_dialog().findAllByLabelText("Optimize").first().click();

cy.intercept("POST", "/api/method/upload_file").as("upload_file");
cy.get_open_dialog().findByRole("button", { name: "Upload" }).click();
cy.wait("@upload_file").its("response.statusCode").should("eq", 200);
cy.get(".modal:visible").should("not.exist");
});
});
26 changes: 0 additions & 26 deletions cypress/integration/form.js
Expand Up @@ -30,32 +30,6 @@ context("Form", () => {
cy.get(".list-row").should("contain", "this is a test todo");
});

it("navigates between documents with child table list filters applied", () => {
cy.visit("/app/contact");

cy.clear_filters();
cy.get('.standard-filter-section [data-fieldname="name"] input')
.type("Test Form Contact 3")
.blur();
cy.click_listview_row_item_with_text("Test Form Contact 3");

cy.get("#page-Contact .page-head").findByTitle("Test Form Contact 3").should("exist");
cy.get(".prev-doc").should("be.visible").click();
cy.get(".msgprint-dialog .modal-body").contains("No further records").should("be.visible");
cy.hide_dialog();

cy.get("#page-Contact .page-head").findByTitle("Test Form Contact 3").should("exist");
cy.get(".next-doc").should("be.visible").click();
cy.get(".msgprint-dialog .modal-body").contains("No further records").should("be.visible");
cy.hide_dialog();

cy.get("#page-Contact .page-head").findByTitle("Test Form Contact 3").should("exist");

// clear filters
cy.visit("/app/contact");
cy.clear_filters();
});

it("validates behaviour of Data options validations in child table", () => {
// test email validations for set_invalid controller
let website_input = "website.in";
Expand Down
42 changes: 0 additions & 42 deletions cypress/integration/list_paging.js

This file was deleted.

15 changes: 0 additions & 15 deletions cypress/integration/list_view.js
Expand Up @@ -10,21 +10,6 @@ context("List View", () => {
});
});

it("Keep checkbox checked after Refresh", { scrollBehavior: false }, () => {
cy.go_to_list("ToDo");
cy.clear_filters();
cy.get(".list-row-container .list-row-checkbox").click({
multiple: true,
force: true,
});
cy.get(".actions-btn-group button").contains("Actions").should("be.visible");
cy.intercept("/api/method/frappe.desk.reportview.get").as("list-refresh");
cy.wait(3000); // wait before you hit another refresh
cy.get('button[data-original-title="Refresh"]').click();
cy.wait("@list-refresh");
cy.get(".list-row-container .list-row-checkbox:checked").should("be.visible");
});

it('enables "Actions" button', { scrollBehavior: false }, () => {
const actions = [
"Approve",
Expand Down
38 changes: 0 additions & 38 deletions cypress/integration/list_view_settings.js

This file was deleted.