Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: functionality to assign users by user group #26044

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ashish-greycube
Copy link
Contributor

a new functionality to assign users using user group
below is the animated gif showing it in action

@ashish-greycube ashish-greycube requested a review from a team as a code owner April 18, 2024 11:23
@ashish-greycube ashish-greycube requested review from akhilnarang and removed request for a team April 18, 2024 11:23
@Sakshi-Greycube
Copy link

pr

Copy link
Member

@ankush ankush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This looks bad in UI, can we keep it single column instead?

frappe/public/js/frappe/form/sidebar/assign_to.js Outdated Show resolved Hide resolved
frappe/public/js/frappe/form/sidebar/assign_to.js Outdated Show resolved Hide resolved
frappe/public/js/frappe/form/sidebar/assign_to.js Outdated Show resolved Hide resolved
@ashish-greycube
Copy link
Contributor Author

image

This looks bad in UI, can we keep it single column instead?
w/o column break , it looks like below..i am not sure, if it looks great

image

@ashish-greycube
Copy link
Contributor Author

all four review comments are done.

@Sakshi-Greycube
Copy link

Sakshi-Greycube commented Apr 24, 2024

Below is the new animated gif after fixing 4 review comments:

pr1

@akhilnarang
Copy link
Member

Linter is still failing as code isn't formatted.

https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist#linting

@ashish-greycube
Copy link
Contributor Author

ashish-greycube commented Apr 25, 2024

Linter is still failing as code isn't formatted.

https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist#linting

Linter is not failing, i did install that utility
Pl check Details, it says Documentation fail
There is GIF attached with the PR which suffices to explain functionality
@akhilnarang , let me know if i am missing something. thanks

@akhilnarang
Copy link
Member

Linter is still failing as code isn't formatted.
https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist#linting

Linter is not failing, i did install that utility Pl check Details, it says Documentation fail There is GIF attached with the PR which suffices to explain functionality @akhilnarang , let me know if i am missing something. thanks

You can view the linter failure logs here: https://github.com/frappe/frappe/actions/runs/8811181962/job/24184735736?pr=26044

If you installed the pre-commit tool, then you can run pre-commit install, once its setup, it'll automatically run every time you commit in the future.

For now you can run pre-commit run --all-files and it'll format the code as required.

@ashish-greycube
Copy link
Contributor Author

Thanks @akhilnarang for all the help. I think we are good to go now.

@akhilnarang akhilnarang requested a review from ankush April 26, 2024 07:13
@akhilnarang akhilnarang enabled auto-merge (squash) April 26, 2024 07:13
@durve-greycube
Copy link

@ankush , When time permits please review and merge this PR, thanks.

@akhilnarang akhilnarang removed the request for review from ankush May 2, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants