fix: undefined variable name fixed in dark.scss #23646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: release v13
## [13.51.3](frappe/frappe@v13.51.2...v13.51.3) (2023-03-28) ### Bug Fixes * Avoid list update if user is doing some bulk operation (backport [frappe#20432](frappe#20432)) ([frappe#20444](frappe#20444)) ([5248b74](frappe@5248b74)) * dont clear doc on list_update ([0cd4288](frappe@0cd4288)) * Get translated value for child tables in print format ([02469f7](frappe@02469f7)) * hard link environment variable ([frappe#20467](frappe#20467)) ([frappe#20468](frappe#20468)) ([e388baf](frappe@e388baf)) * Permission error while processing role based notifications (backport [frappe#20315](frappe#20315)) ([frappe#20426](frappe#20426)) ([4e2daaa](frappe@4e2daaa)) * pin pymysql [v13] ([933e6bf](frappe@933e6bf)) * reload website settings to avoid chat module failure ([frappe#20465](frappe#20465)) ([7e52a47](frappe@7e52a47)), closes [frappe#2019-09-23](frappe#2019) [frappe#2020-10-17](frappe#2020) [frappe#2020-08-28](frappe#2020) [frappe#2020-08-25](frappe#2020) * suggested email ids in New Email dialog (backport [frappe#20319](frappe#20319)) ([frappe#20473](frappe#20473)) ([20bbd7a](frappe@20bbd7a))
chore: release v13
# [13.52.0](frappe/frappe@v13.51.3...v13.52.0) (2023-04-04) ### Bug Fixes * better error logging while sending email ([frappe#20570](frappe#20570)) ([8ae4d55](frappe@8ae4d55)) * cannot restore cancelled document if workflow is active ([6206dc0](frappe@6206dc0)) * escape HTML instead of sanitizing ([68ad9cf](frappe@68ad9cf)) * fix address query for postgres ([616dd8b](frappe@616dd8b)), closes [/github.com/frappe/pull/20537#ref-pullrequest-1645575433](https://github.com//github.com/frappe/frappe/pull/20537/issues/ref-pullrequest-1645575433) * get workflow_state_fieldname instead of setting workflow_state to none ([3249aa2](frappe@3249aa2)) * removed unnecessary usage of `[@frappe](https://github.com/frappe).whitelist` ([frappe#20503](frappe#20503)) ([frappe#20562](frappe#20562)) ([08398cb](frappe@08398cb)) * rewrite query for postgres ([frappe#20557](frappe#20557)) ([frappe#20558](frappe#20558)) ([e400c5f](frappe@e400c5f)) ### Features * Disable Sharing globally ([frappe#20318](frappe#20318)) [backport] ([frappe#20500](frappe#20500)) ([758873c](frappe@758873c)) * make workflow state translatable ([frappe#20412](frappe#20412)) ([frappe#20501](frappe#20501)) ([1545fbd](frappe@1545fbd)) ### Performance Improvements * Faster address query with explicit joins (backport [frappe#20537](frappe#20537)) ([frappe#20539](frappe#20539)) ([955a723](frappe@955a723))
chore: release v13
# [13.53.0](frappe/frappe@v13.52.0...v13.53.0) (2023-04-11) ### Bug Fixes * allow `reset_otp_secret` only if Two Factor Auth is enabled (backport [frappe#20506](frappe#20506)) ([frappe#20560](frappe#20560)) ([e8025a4](frappe@e8025a4)) * better permission error for query_report ([frappe#20643](frappe#20643)) ([frappe#20646](frappe#20646)) ([d972af8](frappe@d972af8)) * change z-index of freeze component to make it appear above all components ([1878b87](frappe@1878b87)), closes [frappe#20538](frappe#20538) * child row form should be above freeze screen ([9201e84](frappe@9201e84)) * client script add to instead of replace ([0c7ac16](frappe@0c7ac16)) * client_script default value ([9ed7851](frappe@9ed7851)) * german translation of workflow state ([frappe#20609](frappe#20609)) ([frappe#20615](frappe#20615)) ([3769bdf](frappe@3769bdf)) * **grid row:** fix prettier hook check ([9309687](frappe@9309687)) * **grid row:** fix update_docfield_property function not updating grid row ([558f908](frappe@558f908)) * **ListView:** Evaluate sort_field sort_order within listviews based on DocTypes Definition ([frappe#20482](frappe#20482)) ([ba3cf84](frappe@ba3cf84)) * log requests even if no response ([frappe#20638](frappe#20638)) ([frappe#20639](frappe#20639)) ([ae4f7dd](frappe@ae4f7dd)) * no optional chaining in v13 ([d08627b](frappe@d08627b)) * **pretty-date:** plural form when the value is 1 ([frappe#20619](frappe#20619)) ([frappe#20641](frappe#20641)) ([4d6b776](frappe@4d6b776)) * validate if doctype exists before syncing customisations ([frappe#20598](frappe#20598)) ([frappe#20644](frappe#20644)) ([32ba65f](frappe@32ba65f)) ### Features * add context to confirm dailog ([0e21299](frappe@0e21299)) * add context to prompt dialog ([1bbf9c9](frappe@1bbf9c9)) * make report name translatable (backport [frappe#20608](frappe#20608)) ([frappe#20617](frappe#20617)) ([a92e69e](frappe@a92e69e)) * **minor:** log datetime in worker log (backport [frappe#20414](frappe#20414)) ([frappe#20569](frappe#20569)) ([dccb6af](frappe@dccb6af))
…20659 fix: update property if field exist (backport frappe#20658) (backport frappe#20659)
## [13.53.1](frappe/frappe@v13.53.0...v13.53.1) (2023-04-12) ### Bug Fixes * update property if field exist ([58fc23d](frappe@58fc23d))
## [13.53.2](frappe/frappe@v13.53.1...v13.53.2) (2023-04-14) ### Bug Fixes * Remove unnecessary code to avoid timestamp conflict ([3ef34c2](frappe@3ef34c2))
chore: release v13
# [13.54.0](frappe/frappe@v13.53.2...v13.54.0) (2023-04-18) ### Bug Fixes * allow filter values to be saved in custom report ([2499aba](frappe@2499aba)) * allow workflow action master rename ([afc05c4](frappe@afc05c4)) * bulk update (backport [frappe#20522](frappe#20522)) ([8e51fb0](frappe@8e51fb0)) * clear all filters when in list view (backport [frappe#20342](frappe#20342)) ([frappe#20747](frappe#20747)) ([8fa1580](frappe@8fa1580)) * filter with capitalized operator was getting bypassed (backport [frappe#20682](frappe#20682)) ([frappe#20683](frappe#20683)) ([12cd78d](frappe@12cd78d)) * group buttons are overlapping (backport [frappe#20671](frappe#20671)) ([frappe#20688](frappe#20688)) ([b0183ed](frappe@b0183ed)) * Initialize "r" to avoid UnboundLocalError ([frappe#19630](frappe#19630)) ([frappe#20758](frappe#20758)) ([c852197](frappe@c852197)) * prioritize modal over freeze in grid-form ([ed85ea2](frappe@ed85ea2)) * remove guest permission from language (backport [frappe#20677](frappe#20677)) ([frappe#20690](frappe#20690)) ([2553a7e](frappe@2553a7e)) * Remove unnecessary code to avoid timestamp conflict ([410d976](frappe@410d976)) * stale `frappe.local` (backport [frappe#20695](frappe#20695)) ([frappe#20700](frappe#20700)) ([bfd9dd0](frappe@bfd9dd0)) * update property if field exist ([8171c65](frappe@8171c65)) ### Features * custom info in frappe monitor (backport [frappe#18214](frappe#18214)) ([frappe#20686](frappe#20686)) ([87d52f5](frappe@87d52f5)), closes [frappe#18259](frappe#18259)
(cherry picked from commit 93f7fa1)
…20793 fix: charts on dashboard not loading (backport frappe#20793)
## [13.54.1](frappe/frappe@v13.54.0...v13.54.1) (2023-04-20) ### Bug Fixes * charts on dashboard not loading ([c0ba715](frappe@c0ba715))
(cherry picked from commit b4b6b66) Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
# [13.55.0](frappe/frappe@v13.54.1...v13.55.0) (2023-04-20) ### Features * email oauth (v13) ([frappe#20790](frappe#20790)) ([frappe#20800](frappe#20800)) ([bef1dc6](frappe@bef1dc6))
chore: release v13
# [13.56.0](frappe/frappe@v13.55.0...v13.56.0) (2023-04-25) ### Bug Fixes * charts on dashboard not loading ([a00405c](frappe@a00405c)) * clear cache on delete of prop setters ([7fac775](frappe@7fac775)) * format filter values in report print view (backport [frappe#20717](frappe#20717)) ([frappe#20761](frappe#20761)) ([6fc359f](frappe@6fc359f)) * make role info translatable (backport [frappe#20813](frappe#20813)) ([frappe#20828](frappe#20828)) ([265d9b2](frappe@265d9b2)) ### Features * email oauth (v13) ([frappe#20790](frappe#20790)) ([b4b6b66](frappe@b4b6b66))
chore: release v13
## [13.56.1](frappe/frappe@v13.56.0...v13.56.1) (2023-05-02) ### Bug Fixes * cast primary value if fieldtype is present and directly map function over lambda call ([frappe#20835](frappe#20835)) ([9c52be4](frappe@9c52be4)) * **workflow:** add whitelisted functions permissions checks (backport [frappe#20575](frappe#20575)) ([frappe#20846](frappe#20846)) ([1c9d43b](frappe@1c9d43b))
chore: release v13
## [13.56.2](frappe/frappe@v13.56.1...v13.56.2) (2023-05-09) ### Bug Fixes * ensure that `get_last_email` returns the most recent email ([frappe#20711](frappe#20711)) ([d416159](frappe@d416159)) * make operator in link filters translatable (backport [frappe#20884](frappe#20884)) ([frappe#20910](frappe#20910)) ([688a2b4](frappe@688a2b4)) * merge conflict ([64d5c8f](frappe@64d5c8f)) * translate lowercase operators to german ([frappe#20912](frappe#20912)) ([frappe#20915](frappe#20915)) ([598bdaf](frappe@598bdaf)) * use smaller font only if the report doesnt have a standard print format (backport [frappe#20878](frappe#20878)) ([frappe#20946](frappe#20946)) ([8b0c1f8](frappe@8b0c1f8))
chore: release v13
## [13.56.3](frappe/frappe@v13.56.2...v13.56.3) (2023-05-16) ### Bug Fixes * avoid internal arrays in get_all_docs (backport [frappe#20950](frappe#20950)) ([frappe#20958](frappe#20958)) ([43b051f](frappe@43b051f)) * Check permission_type in get_permitted_fieldnames [v13] (backport [frappe#20905](frappe#20905)) ([frappe#20955](frappe#20955)) ([ea6d350](frappe@ea6d350)) * don't use default filters for auto-email report ([frappe#20876](frappe#20876)) ([7d7500f](frappe@7d7500f)) * filters while exporting or creating new auto email reports for custom reports (backport [frappe#20960](frappe#20960)) ([frappe#21020](frappe#21020)) ([723ec9a](frappe@723ec9a)) * report print view not working ([frappe#21002](frappe#21002)) ([frappe#21003](frappe#21003)) ([ca73d72](frappe@ca73d72))
chore: release v13
## [13.56.4](frappe/frappe@v13.56.3...v13.56.4) (2023-05-23) ### Bug Fixes * frappe.get_palette when text is undefined ([frappe#21033](frappe#21033)) ([frappe#21034](frappe#21034)) ([1557d68](frappe@1557d68)) * incorrect caching of `is_owner` permissions ([frappe#21048](frappe#21048)) ([frappe#21052](frappe#21052)) ([a9acf3f](frappe@a9acf3f)) * using 'Equals' and 'Is' on multiselect throws error ([6c57a26](frappe@6c57a26))
chore: release v13
## [13.58.19](frappe/frappe@v13.58.18...v13.58.19) (2023-11-28) ### Bug Fixes * default Email Group in system language ([5a8d2cb](frappe@5a8d2cb))
error-bg resp. `field.df.invalid` or `field.set_invalid()` has now an effect when using the dark theme.
sigger
changed the title
shariquerik
requested changes
Dec 8, 2023
shariquerik
added
backport develop
mergify bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
(cherry picked from commit 5fcde3a)
mergify bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
(cherry picked from commit 5fcde3a)
mergify bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
(cherry picked from commit 5fcde3a)
shariquerik
pushed a commit
that referenced
this pull request
Dec 8, 2023
shariquerik
pushed a commit
that referenced
this pull request
Dec 8, 2023
shariquerik
pushed a commit
that referenced
this pull request
Dec 8, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
# [15.5.0](v15.4.1...v15.5.0) (2023-12-12) ### Bug Fixes * Add filter in Workspace Card Links Block (backport [#23578](#23578)) ([#23686](#23686)) ([8709738](8709738)) * Avoid duplicate contact names ([#23731](#23731)) ([#23734](#23734)) ([5fb8302](5fb8302)) * change webhook header types to small text ([#23722](#23722)) ([#23727](#23727)) ([b433165](b433165)) * Color indicator style ([709e6eb](709e6eb)) * correct error message ([#23746](#23746)) ([#23748](#23748)) ([4c7124c](4c7124c)) * Correct fallback for social login key ([045d059](045d059)) * ecsape search string ([#23717](#23717)) ([#23720](#23720)) ([d6fbdc9](d6fbdc9)) * escape username on avatar control ([#23713](#23713)) ([#23716](#23716)) ([980dae7](980dae7)) * get users for leaderboard ([#23740](#23740)) ([8234d79](8234d79)) * ignore duplicate contact creation ([#23423](#23423)) ([#23730](#23730)) ([cd50875](cd50875)) * ignore if controller doesn't have `get_list` attr ([#23736](#23736)) ([#23742](#23742)) ([0248c07](0248c07)) * Modified Number system for Nepal ([#23613](#23613)) ([#23634](#23634)) ([29ef929](29ef929)) * only update primary action if it is new action is provided ([0de2b28](0de2b28)) * pass filter to formatter to handle custom logic ([b6e53d4](b6e53d4)) * prioritize link_title if value != link_title ([4efd750](4efd750)) * remove redundant breadcrumbs ([#23653](#23653)) ([4be06db](4be06db)) * **Report View:** clear checked items ([049e066](049e066)) * **sentry:** set the user's name correctly ([859fd74](859fd74)) * set correct sentry tags ([cc04b63](cc04b63)) * Show server script name in traceback ([#23676](#23676)) ([132ac1d](132ac1d)) * undefined variable name fixed in dark.scss (backport [#23646](#23646)) ([#23695](#23695)) ([0fbe079](0fbe079)) * use encoded filename for arabic (latin) language while exporting ([82027ab](82027ab)) * **UX:** Add group by information in report view URLs ([#23547](#23547)) ([#23745](#23745)) ([07ade2c](07ade2c)) * **Virtual DocType:** don't call db get_value in link field validation ([#23620](#23620)) ([e019f13](e019f13)) ### Features * **minor:** child table field as standard filter in list view ([#23625](#23625)) ([ec7aedc](ec7aedc)) ### Reverts * Revert "feat: wkhtmltopdf logging (#19935)" ([52621d9](52621d9)), closes [#19935](#19935)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
## [13.58.20](v13.58.19...v13.58.20) (2023-12-12) ### Bug Fixes * don't stop next unattached file from being attached ([b138be8](b138be8)) * ecsape search string ([#23717](#23717)) ([#23718](#23718)) ([4a450b7](4a450b7)) * escape username on avatar control ([#23713](#23713)) ([#23714](#23714)) ([c411dc2](c411dc2)) * get users for leaderboard ([ef790d3](ef790d3)) * strip html the printview's key value ([#23606](#23606)) ([#23611](#23611)) ([9e50c9b](9e50c9b)) * undefined variable name fixed in dark.scss ([#23646](#23646)) ([5fcde3a](5fcde3a)) * Update notification_settings.js ([bfd9622](bfd9622))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
# [14.59.0](v14.58.0...v14.59.0) (2023-12-12) ### Bug Fixes * Add filter in Workspace Card Links Block (backport [#23578](#23578)) ([#23685](#23685)) ([29bcf7b](29bcf7b)) * Avoid duplicate contact names ([#23731](#23731)) ([#23733](#23733)) ([78aecd7](78aecd7)) * correct error message ([#23746](#23746)) ([#23747](#23747)) ([7b608e2](7b608e2)) * dont stop next unattached file from being attached if file_url of first file is invalid ([e6dacf0](e6dacf0)) * dont stop next unattached file from being unattached ([394fd77](394fd77)) * ecsape search string ([#23717](#23717)) ([#23719](#23719)) ([6d670fd](6d670fd)) * escape username on avatar control ([#23713](#23713)) ([#23715](#23715)) ([2bc4261](2bc4261)) * german translations for navbar toggles (backport [#23478](#23478)) ([#23502](#23502)) ([da4606c](da4606c)) * get users for leaderboard ([#23739](#23739)) ([33b7066](33b7066)) * ignore if controller doesn't have `get_list` attr ([#23736](#23736)) ([#23741](#23741)) ([649876c](649876c)) * ignore rtlcss for cropperjs ([bf784f9](bf784f9)) * Modified Number system for Nepal ([#23613](#23613)) ([#23633](#23633)) ([fd6cc46](fd6cc46)) * only update primary action if it is new action is provided ([06f5611](06f5611)) * pass filter to formatter to handle custom logic ([eda3dd2](eda3dd2)) * prioritize link_title if value != link_title ([268a2d7](268a2d7)) * remove redundant breadcrumbs ([#23654](#23654)) ([0c4288d](0c4288d)) * **Report View:** clear checked items ([293cd3c](293cd3c)) * undefined variable name fixed in dark.scss (backport [#23646](#23646)) ([#23694](#23694)) ([c2daee6](c2daee6)) * use encoded filename for arabic (latin) language while exporting ([df165dd](df165dd)) * **Virtual DocType:** don't call db get_value in link field validation ([#23620](#23620)) ([1d240a2](1d240a2)) ### Features * add sender_name_field ([eec8e1e](eec8e1e)) * **minor:** child table field as standard filter in list view ([#23625](#23625)) ([40b32ab](40b32ab)) * **minor:** child table field as standard filter in list view (backport [#23625](#23625)) ([#23687](#23687)) ([7342b6d](7342b6d)) * set sender_name_field in reference doc ([5de64d8](5de64d8))
|
🎉 This PR is included in version 13.58.20 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The style class
error-bgresp.field.df.invalidorfield.set_invalid()has now an effect when using the dark theme.The previously used variable is not defined in dark-mode, after this PR it is.
This PR fixes the problem:
When e.g. editing a doctype with field validation and you made an invalid input you get a red-ish colored background to highlight the location of the invalid input (via style class
error-bg). This works fine in the light-mode (Frappe Light), but not in the dark mode (Timeless Night).This PR fixes this in the dark mode.
before fix
Invalid field in light-mode:
Invalid field in dark-mode:
after fix
Invalid field in dark-mode:
closes #23646