Skip to content

Commit

Permalink
fix: comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Mate Laszlo Valko committed May 9, 2024
1 parent 1cebdb2 commit 4ca4372
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions frappe/core/doctype/data_import/test_importer.py
Expand Up @@ -65,7 +65,8 @@ def test_data_validation_semicolon_failure(self):

data_import = self.get_importer_semicolon(doctype_name, import_file)
doc = data_import.get_preview_from_template().get("data", [{}])
# if semicolon delimiter detection fails, and falls back to comma, detected colum number will be 2 (+1 id) instead of
# if semicolon delimiter detection fails, and falls back to comma,
# colum number will be less than 15 -> 2 (+1 id)
self.assertLessEqual(len(doc[0]), 15)

def test_data_import_preview(self):
Expand Down Expand Up @@ -112,7 +113,6 @@ def test_data_import_without_mandatory_values(self):
"Title is required",
)

#
def test_data_import_update(self):
existing_doc = frappe.get_doc(
doctype=doctype_name,
Expand Down Expand Up @@ -162,7 +162,7 @@ def get_importer_semicolon(self, doctype, import_file, update=False):
data_import.import_type = "Insert New Records" if not update else "Update Existing Records"
data_import.reference_doctype = doctype
data_import.import_file = import_file.file_url
# deliberatly overwrite default delimiter options here, causing to fail when parsing ;
# deliberately overwrite default delimiter options here, causing to fail when parsing `;`
data_import.delimiter_options = ","
data_import.insert()
frappe.db.commit() # nosemgrep
Expand Down

0 comments on commit 4ca4372

Please sign in to comment.