Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Setup Wizard] Use setup stages #12000

Merged
merged 4 commits into from Dec 21, 2017
Merged

[Setup Wizard] Use setup stages #12000

merged 4 commits into from Dec 21, 2017

Conversation

pratu16x7
Copy link
Contributor

@pratu16x7 pratu16x7 commented Dec 14, 2017 •
edited

Adapted from (and will need): frappe/frappe#4618

__setup_progress

__setup_fail

Removed Setup Already complete, will proceed to last commit in case of restart.

  • Show the users a message in case of post-commit setup fail, notifying that it is a problem to be fixed by us. Once we get inputs at this stage, we'll eventually be able to figure out which are the cases in which this happens.

@pratu16x7 pratu16x7 mentioned this pull request Dec 14, 2017
Merged
@pratu16x7 pratu16x7 changed the title Setup stages Use setup stages Dec 14, 2017
@pratu16x7 pratu16x7 changed the title Use setup stages [Setup Wizard] Use setup stages Dec 14, 2017
@nabinhait nabinhait merged commit 8b0b56d into frappe:develop Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pratu16x7 @nabinhait