Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LetMeShip): use correct fields for creating shipment #22

Merged
merged 1 commit into from Mar 30, 2024

Conversation

thejoe8495
Copy link
Contributor

The error in ticket #20 was an exception on the letmeship API. The response fields does not exists and it was an python error. After the API works correct the error was clear and send to the client.

The fields in the api changed a little.

@barredterra barredterra changed the title repair letmeship response errors, closes #20 fix(LetMeShip): use correct fields for creating shipment Mar 30, 2024
@barredterra barredterra merged commit 3ce0099 into frappe:version-14 Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants