edit files using a relative path when possible #71

fabi1cazenave · 2018-11-30T22:45:27Z

Files that have been chosen with Ranger are open in Vim / Neovim with their absolute paths, which is a pity.

This quick patch allows to use the relative path (from Vim’s current working directory) when possible.

francoiscabrol · 2018-12-01T17:42:45Z

Hey thank you for your contribution.
But I tried locally and I found one feature broken: if I try to open the current directory in neovim with the command nvim . and then I choose a file, I get the error

Error in EditFiles
E492: Unknown command editplugin/ranger.vim

fabi1cazenave · 2018-12-01T18:43:47Z

Oh, good catch. Looking at it.

I confess I hadn’t really tried the let g:ranger_replace_netrw = 1 trick yet.

fabi1cazenave · 2018-12-02T00:41:42Z

[EDIT] Got it, see commit 98e3e73, line 124.

Without this PR, the command was edit/home/user/file.ext, which is understood by nvim (the space between the command and the path is not needed because the path starts with a slash). With this PR, the command became editfile.ext, which is not understood.

fabi1cazenave · 2018-12-02T00:58:51Z

In fact I find the trailing space in edit_cmd a bit error-prone, and I think it would be safer to add this space explicitly in the EditFiles function instead.

That’s what I did in commit 60146fb, but it works without this commit. Feel free to drop it if you prefer keeping the code the other way.

EDIT: updated commit references after a rebase.

Having a trailing space in the `edit_cmd` variable is error-prone. Adding a space between this command and the file path in the `EditFiles` function should be safer.

francoiscabrol · 2018-12-10T18:13:32Z

plugin/ranger.vim

+
+function! s:GetRangerCmd(path)
+  return s:ranger_command . ' --choosefiles=' . s:choice_file_path .
+      \ (isdirectory(a:path) ? ' "' : ' --selectfile="') . expand(a:path) . '"'


I don't know why but the path is not concatenated correctly and that breaks the default behaviour:

if you open a file in vim

then you open ranger in the same window

it should select the file in Ranger and it does not (see the command RangerCurrentFile).

fabi1cazenave force-pushed the relative_path branch from f8fbf8e to b29c0a5 Compare November 30, 2018 23:24

fabi1cazenave force-pushed the relative_path branch from e4388ee to dbb963f Compare December 2, 2018 00:48

fabi1cazenave added 2 commits December 2, 2018 09:55

edit files using a relative path when possible

98e3e73

don't include a trailing space in edit_cmd

60146fb

Having a trailing space in the `edit_cmd` variable is error-prone. Adding a space between this command and the file path in the `EditFiles` function should be safer.

fabi1cazenave force-pushed the relative_path branch from 1bbdc81 to 60146fb Compare December 2, 2018 09:01

francoiscabrol reviewed Dec 10, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

edit files using a relative path when possible #71

edit files using a relative path when possible #71

fabi1cazenave commented Nov 30, 2018

francoiscabrol commented Dec 1, 2018 •

edited

fabi1cazenave commented Dec 1, 2018

fabi1cazenave commented Dec 2, 2018 •

edited

fabi1cazenave commented Dec 2, 2018 •

edited

francoiscabrol Dec 10, 2018

edit files using a relative path when possible #71

Are you sure you want to change the base?

edit files using a relative path when possible #71

Conversation

fabi1cazenave commented Nov 30, 2018

francoiscabrol commented Dec 1, 2018 • edited

fabi1cazenave commented Dec 1, 2018

fabi1cazenave commented Dec 2, 2018 • edited

fabi1cazenave commented Dec 2, 2018 • edited

francoiscabrol Dec 10, 2018

Choose a reason for hiding this comment

francoiscabrol commented Dec 1, 2018 •

edited

fabi1cazenave commented Dec 2, 2018 •

edited

fabi1cazenave commented Dec 2, 2018 •

edited