-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab feature #65
base: master
Are you sure you want to change the base?
Tab feature #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was removed because it caused problems with vim-gitgutter
mmm, as you know I'm still learning git(hub), that 'review' was meant to accompany commit |
I'm not sure what to do when the user edits a directory but doesn't choose a file.
4b is easy, we determine what the alternate buffer is in the directory buffer before opening Ranger, and pass it as a window variable. |
About 4a, I found a neovim function |
I don't think we can rely on the buffer numbers, that would work in this simple example, but I think the buffer numbers do not represent the order in which buffers are visited, only the order in which they were opened, there's a big difference most of the time. |
If there's a function that returns a list of the order in which buffers have been visited for the current session or something that would be exactly what we need |
hum yes I found this PR of fzf junegunn/fzf.vim@852cfa0#diff-7274b7c6c87526542ef9087f2e997dfaR411 that solve this specific problem of getting the buffers list ordered... but it doesn't look obvious. The related issue is junegunn/fzf.vim#100 |
That is quite similar to the workaround I had in my mind, except that I wasn't thinking to use a timestamp, just a window variable (w:old_alternate) to set on BufLeave with that buffer's alternate, so a new buffer in the window can look into that. I just didn't want to have to do this for every BufLeave |
Any plans on merging this @francoiscabrol? |
Implements the following: