Merge pull request #911 from frab/missing_translated_for_shared_perso…

…n_form Missing permitted params for shared person form
frab · Oct 20, 2022 · 32008a7 · 32008a7
2 parents 3b08ee6 + cbee83f
commit 32008a7
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 8 deletions.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
@@ -37,6 +37,13 @@ def set_locale
     end
   end
 
+  def translated_person_params
+    # Person can be edited without a conference, so allow all languages
+    translated_params = Language.all_normalized.map { |l|
+      [:"abstract_#{l}", :"description_#{l}"]
+    }.flatten
+  end
+
   def load_conference
     @conference = conference_from_params
     @conference ||= conference_from_session

diff --git a/app/controllers/cfp/people_controller.rb b/app/controllers/cfp/people_controller.rb
@@ -106,7 +106,9 @@ def update
 
   def person_params
     params.require(:person).permit(
-      :first_name, :last_name, :public_name, :email, :email_public, :gender, :avatar, :abstract, :description, :include_in_mailings,
+      :first_name, :last_name, :public_name, :email, :email_public, :gender, :avatar,
+      :include_in_mailings,
+      *translated_person_params,
       im_accounts_attributes: %i(id im_type im_address _destroy),
       languages_attributes: %i(id code _destroy),
       links_attributes: %i(id title url _destroy),

diff --git a/app/controllers/crew_profiles_controller.rb b/app/controllers/crew_profiles_controller.rb
@@ -20,7 +20,9 @@ def update
 
   def person_params
     params.require(:person).permit(
-      :first_name, :last_name, :public_name, :email, :email_public, :gender, :avatar, :abstract, :description, :include_in_mailings, :note,
+      :first_name, :last_name, :public_name, :email, :email_public, :gender, :avatar,
+      :include_in_mailings, :note,
+      *translated_person_params,
       im_accounts_attributes: %i(id im_type im_address _destroy),
       languages_attributes: %i(id code _destroy),
       links_attributes: %i(id title url _destroy),

diff --git a/app/controllers/people_controller.rb b/app/controllers/people_controller.rb
@@ -153,15 +153,10 @@ def search(people, search_by_id = false)
   end
 
   def person_params
-    # Person can be edited without a conference, so allow all languages
-    translated_params = Language.all_normalized.map { |l|
-      [:"abstract_#{l}", :"description_#{l}"]
-    }.flatten
-
     params.require(:person).permit(
       :first_name, :last_name, :public_name, :email, :email_public, :gender, :avatar,
       :include_in_mailings, :note,
-      *translated_params,
+      *translated_person_params,
       im_accounts_attributes: %i(id im_type im_address _destroy),
       languages_attributes: %i(id code _destroy),
       links_attributes: %i(id title url _destroy),