Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): Upgrade reconnecting-websocket to 4.1.10. #41

Merged

Conversation

unn
Copy link
Contributor

@unn unn commented Dec 24, 2018

Addresses #39. I had to rm yarn.lock and yarn install and due to a upstream issue in yarnpkg/yarn#5962 (comment)

@amazingrando
Copy link
Member

@unn Thanks for the PR. 👍 I've tested this and it works, however, I'm a JS novice(ish) so I'm going to ask for another person to review it as well before we merge.

Copy link
Contributor

@infiniteluke infiniteluke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and saw no reconnection messages during game play 🎉

lgtm

@infiniteluke infiniteluke merged commit 3e86511 into fourkitchens:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants