Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings from dart-sass for color values with &.#{$name} #12622

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix warnings from dart-sass for color values with &.#{$name} #12622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion scss/components/_badge.scss
View file
Open in desktop
Expand Up @@ -54,7 +54,7 @@ $badge-font-size: 0.6rem !default;
color: $badge-color;

@each $name, $color in $badge-palette {
&.#{$name} {
&.#{"" + $name} {
background: $color;
color: color-pick-contrast($color, ($badge-color, $badge-color-alt));
}
Expand Down
6 changes: 3 additions & 3 deletions scss/components/_button-group.scss
View file
Open in desktop
Expand Up @@ -242,13 +242,13 @@ $buttongroup-radius-on-each: true !default;

@each $name, $color in $button-palette {
@if($button-fill != $filling) {
$individual-selector: ' #{$buttongroup-child-selector}.#{$name}';
&.#{$name} #{$buttongroup-child-selector}, &#{$individual-selector} {
$individual-selector: ' #{$buttongroup-child-selector}.#{"" + $name}';
&.#{"" + $name} #{$buttongroup-child-selector}, &#{$individual-selector} {
@include button-fill-style($filling, $color, auto, auto);
}
}
@else {
&.#{$name} #{$buttongroup-child-selector} {
&.#{"" + $name} #{$buttongroup-child-selector} {
@include button-fill-style($filling, $color, auto, auto);
}
}
Expand Down
4 changes: 2 additions & 2 deletions scss/components/_button.scss
View file
Open in desktop
Expand Up @@ -374,7 +374,7 @@ $button-responsive-expanded: false !default;
@include button-fill-style($filling);

@each $name, $color in $button-palette {
&.#{$name} {
&.#{"" + $name} {
@include button-fill-style($filling, $color, auto, auto);
}
}
Expand Down Expand Up @@ -402,7 +402,7 @@ $button-responsive-expanded: false !default;
}

@each $name, $color in $button-palette {
&.#{$name} {
&.#{"" + $name} {
&::after {
border-top-color: $color;
}
Expand Down
2 changes: 1 addition & 1 deletion scss/components/_callout.scss
View file
Open in desktop
Expand Up @@ -94,7 +94,7 @@ $callout-link-tint: 30% !default;
@include callout;

@each $name, $color in $foundation-palette {
&.#{$name} {
&.#{"" + $name} {
@include callout-style($color);
}
}
Expand Down
2 changes: 1 addition & 1 deletion scss/components/_label.scss
View file
Open in desktop
Expand Up @@ -55,7 +55,7 @@ $label-radius: $global-radius !default;
color: $label-color;

@each $name, $color in $label-palette {
&.#{$name} {
&.#{"" + $name} {
background: $color;
color: color-pick-contrast($color, ($label-color, $label-color-alt));
}
Expand Down
2 changes: 1 addition & 1 deletion scss/components/_progress-bar.scss
View file
Open in desktop
Expand Up @@ -43,7 +43,7 @@
@include progress-container;

@each $name, $color in $foundation-palette {
&.#{$name} {
&.#{"" + $name} {
.progress-meter {
background-color: $color;
}
Expand Down
2 changes: 1 addition & 1 deletion scss/forms/_progress.scss
View file
Open in desktop
Expand Up @@ -68,7 +68,7 @@ $progress-radius: $global-radius !default;
}

@each $name, $color in $foundation-palette {
&.#{$name} {
&.#{"" + $name} {
// Internet Explorer sets the fill with color
color: $color;

Expand Down