Skip to content

Commit

Permalink
Merge branch 'release/v6.8.0'
Browse files Browse the repository at this point in the history
  • Loading branch information
joeworkman committed Aug 18, 2023
2 parents f3267f2 + e7cae6c commit 46769fe
Show file tree
Hide file tree
Showing 175 changed files with 31,559 additions and 33,085 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/main.yml
Expand Up @@ -4,11 +4,11 @@ on: [push, pull_request]

jobs:
build_latest_browserstack:
name: Node 14 with browserstack
name: Node Latest with browserstack
runs-on: ubuntu-latest
strategy:
matrix:
node: ['14'] # latest (16+) not functional
node: ['20']
steps:
- uses: actions/checkout@v1
- name: install system dependencies
Expand All @@ -24,11 +24,11 @@ jobs:
run: yarn test:javascript:browserstack

build_latest:
name: Node 14
name: Node Latest
runs-on: ubuntu-latest
strategy:
matrix:
node: ['14'] # latest (16+) not functional
node: ['20'] # latest (16+) not functional
steps:
- uses: actions/checkout@v1
- name: install system dependencies
Expand All @@ -44,7 +44,7 @@ jobs:
strategy:
matrix:
platform: [ubuntu-latest, macos-latest, windows-latest]
node: [ '12', '14' ]
node: [ '16', '18' ]
name: Node ${{ matrix.node }} (${{ matrix.platform }})
runs-on: ${{ matrix.platform }}
steps:
Expand Down
4 changes: 4 additions & 0 deletions .husky/commit-msg
@@ -0,0 +1,4 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

# node .husky/husky-commit-lint.js --color -e $1
File renamed without changes.
File renamed without changes.
File renamed without changes.
6 changes: 6 additions & 0 deletions .husky/pre-push
@@ -0,0 +1,6 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

# node "$(dirname -- "$0")/husky-push-test.js --color

yarn test
5 changes: 0 additions & 5 deletions .huskyrc.yml

This file was deleted.

2 changes: 1 addition & 1 deletion bower.json
@@ -1,6 +1,6 @@
{
"name": "foundation-sites",
"version": "6.7.5",
"version": "6.8.0",
"description": "The most advanced responsive front-end framework in the world.",
"homepage": "https://get.foundation/sites",
"license": "MIT",
Expand Down

2 comments on commit 46769fe

@JeremyCaney
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, should this not be a breaking change? I.e., reserved for a major version? Or do you not follow semantic versioning? Regardless, I'm excited to ditch a legacy environment to retain compatibility. Thank you for your service.

@joeworkman
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone is running an older version, let's say node 14, they will not be able to install this version. So this will not break their build.

Normally a change of this size would only happen at a major version. However, Foundation 7 already has a path and I did not want Foundation 6 users to not get this benefit.

Please sign in to comment.