Fix build, add Rails 6 support, and update ruby versions #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
force-pushed
the
add-rails-6-support
branch
from
c9ba6c2
to
72c9095
Compare
Removes ruby 2.3.8 from the build matrix because it is end-of-life and fails with Rails 6.
p8
force-pushed
the
add-rails-6-support
branch
from
72c9095
to
9fb4dd5
Compare
p8
changed the title
|
Hi @p8 thanks for this... I wanted to add Foundation to my Rails 6 app and was struggling (brand new to webpacker, not a front-end dev by any means). Does your pull request fix it? Thanks! |
chnikki
approved these changes
Mar 26, 2020
|
Hi @bluemihai, You can reference my fork by using the following in your Gemfile: The "Rails 6 support" is for running the specs on this project. |
|
Will this be merged in soon? |
swiknaba
reviewed
Jan 3, 2021
Comment on lines
+6
to
+8
| - 2.4.9 | ||
| - 2.5.7 | ||
| - 2.6.5 |
There was a problem hiding this comment.
Suggested change
| - 2.4.9 | |
| - 2.5.7 | |
| - 2.6.5 | |
| - 2.4.10 | |
| - 2.5.8 | |
| - 2.6.6 | |
| - 2.7.2 | |
| - 3.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes ruby 2.3.8 from the build matrix because it is end-of-life and
fails with Rails 6.